server: refactor: introduce `AuthUser` interface by paul-marechal · Pull Request #838 · eclipse/openvsx

paul-marechal · 2023-11-25T08:12:32Z

Replace the references to OAuth2User by AuthUser. This allows downstream extenders to more easily contribute alternative OAuth2 providers: If the expected data is stored in different attributes it will be possible to bridge it by implementing the proper AuthUser.

New configuration example:

ovsx:
  oauth2:
    provider: gitlab
    attribute-names:
      gitlab:
        avatar-url: avatar_url
        email: email
        full-name: name
        login-name: username
        provider-url: '' # idk what this is for

spring:
  security:
    oauth2:
      client:
        registration:
          gitlab:
            client-id: [client-id]
            client-secret: [client-secret]
            authorization-grant-type: authorization_code
            redirect-uri: http://[openvsx-host-name]/login/oauth2/code/gitlab
            scope: read_user
            clientName: OpenVSX
        provider:
          gitlab:
            authorization-uri: http://[gitlab-host-name]/oauth/authorize
            token-uri: http://[gitlab-host-name]/oauth/token
            user-info-uri: http://[gitlab-host-name]/api/v4/user
            jwk-set-uri: http://[gitlab-host-name]/oauth/discovery/keys
            user-name-attribute: id

paul-marechal · 2023-11-25T08:14:53Z

Note that there seems to be an issue with formatting in this project...

I'm using VS Code along its Java extension to develop and it often feels like reorganizing or cleaning up imports.

I'd be in favor of keeping the cleanup as part of these changes.

It would be good to look into making auto-formatting part of the build step, maybe as a gradle plugin of some kind?

server/src/main/java/org/eclipse/openvsx/security/DefaultAuthUser.java

paul-marechal · 2024-03-01T18:57:10Z

Rebased my branch.

server/src/main/java/org/eclipse/openvsx/security/AuthUserFactory.java

amvanbaren · 2024-04-29T06:31:07Z

@HeikoBoettger Can you share which additional identity provider you were able to implement using this PR?

HeikoBoettger-KarlStorz · 2024-12-06T13:29:02Z

@HeikoBoettger Can you share which additional identity provider you were able to implement using this PR?

@amvanbaren Somehow I lost my comment. The PR didn't help completely, what is missing is basically a mapping of the login-attribute. One could add a GitLab specific mapping to the code, what I did based on this merge request adding a completely new generic provider type which uses additional setting from the application.yaml file defining for the web-interface what provider to use for the login-link and how to map the login (supporting mapping any of the attributes in the AuthUserFactory).

If the code could be changed to use spring.security.oauth2.client.provider.[providerId].user-name-attribute / providerDetails.userInfoEndpoint.userNameAttributeName as described in https://docs.spring.io/spring-security/reference/servlet/oauth2/login/core.html#oauth2login-sample-application-config. Instead of login I could abuse the GitHub provider entry.

To fully support other providers the UI would require a change to select the login method and the AuthToken inside the UserData class need to be contain a map from provider to token:

openvsx/server/src/main/java/org/eclipse/openvsx/entities/UserData.java

Line 63 in 072bf3e

private AuthToken githubToken;

Or the code gets simplified to just store an AuthToken for one provider at a time. I don't know why there are two fields in the UserData when there is only one provider-String.

HeikoBoettger-KarlStorz · 2024-12-06T13:29:38Z

@paul-marechal Is it possible to rebase this branch on to the latest master?

amvanbaren · 2024-12-09T11:15:39Z

Or the code gets simplified to just store an AuthToken for one provider at a time. I don't know why there are two fields in the UserData when there is only one provider-String.

The githubToken is to login. The eclipseToken is to check the publisher agreement.
We could rename githubToken to loginToken.

paul-marechal · 2024-12-09T16:19:02Z

Ok so I initially didn't want to bother implementing the configuration of attributes because it adds a decent amount of complexity... I changed my mind figuring it might make someone else's life easier.

The configuration may look like this:

ovsx:
  auth:
    attribute-names:
      gitlab:
        avatar-url: awdawd
        email: awdawd
        full-name: awdawd
        login-name: awdawd
        provider-url: awdawd

We don't need to define mappings for github as it's handled by default.

amvanbaren · 2024-12-10T12:23:20Z

@paul-marechal Thanks for providing the configuration. I'll try to configure Google OAuth using this PR.

paul-marechal · 2024-12-10T14:05:25Z

I want to apologize for forgetting to transpose code to handle OidcUserRequest we had to use for our fork... Without it we couldn't access certain attributes.

Second, there's still a need to manually edit the webui code to change the OAuth2 authorization endpoint used from github to whatever you want to reach. I'm not sure if we can somehow get rid of it or make it configurable yet. I will try so it's also less of a hassle...

This PR is slowly growing bigger than what we required on our fork so I hope this will help.

amvanbaren · 2024-12-10T14:14:25Z

there's still a need to manually edit the webui code

Yes, the login url is hardcoded in the webui:

openvsx/webui/src/extension-registry-service.ts

Lines 27 to 29 in 0f5315d

    
           getLoginUrl(): string { 
        
               return createAbsoluteURL([this.serverUrl, 'oauth2', 'authorization', 'github']); 
        
           }

The UserAPI has a login endpoint, but it causes CORS errors:

openvsx/server/src/main/java/org/eclipse/openvsx/UserAPI.java

Lines 72 to 77 in 0f5315d

    
           @GetMapping( 
        
               path = "/login" 
        
           ) 
        
           public ModelAndView login(ModelMap model) { 
        
               return new ModelAndView("redirect:/oauth2/authorization/github", model); 
        
           }

paul-marechal · 2024-12-10T14:21:37Z

I implemented the dynamic redirection based on a server configuration, I didn't encounter a CORS error?

ovsx:
  auth:
    provider: azure

openvsx/server/src/main/java/org/eclipse/openvsx/UserAPI.java

Lines 75 to 80 in 1abe659

    
           @GetMapping( 
        
               path = "/login" 
        
           ) 
        
           public ModelAndView login(ModelMap model) { 
        
               return new ModelAndView("redirect:/oauth2/authorization/" + config.getAuth().getProvider(), model); 
        
           }

paul-marechal · 2024-12-10T14:31:01Z

Using the latest commit I can now assert that no more code changes are required to configure a custom provider (following our use cases) as I was able to completely configure authentication to Azure using only the server spring config. I initially forgot to include a few modifications...

HeikoBoettger-KarlStorz · 2024-12-11T07:16:59Z

@paul-marechal Just to give an early feedback. I compared your changes with the modifications I did on my local branch I was thinking of contributing and it's more or less the same.

One thing I wonder is, do you use the githubToken to store the token in the database (UserData)? The TokenService also contains a switch block with the providers.

paul-marechal · 2024-12-11T10:04:14Z

I didn't find it required to store anything in githubToken.

server/src/main/java/org/eclipse/openvsx/security/OAuth2UserServices.java

HeikoBoettger-KarlStorz · 2024-12-12T09:49:00Z

Note sure whether I did something wrong but I get an error message: "Missing configuration: ovsx.auth.attribute-names.gitlab".
Shouldn't there be an default value.

HeikoBoettger-KarlStorz · 2024-12-12T12:21:07Z

@paul-marechal First of all thank you for this awesome work.

ovsx:
  auth:
    attribute-names:
      gitlab:
        avatar-url: awdawd
        email: awdawd
        full-name: awdawd
        login-name: awdawd
        provider-url: awdawd

I used the following values for gitlab:

ovsx:
  auth:
    attribute-names:
      gitlab:
        avatar-url: avatar_url
        email: email
        full-name: name
        login-name: username

I don't know what to set for the provider-url on gitlab but with this mapping I can confirm that I am able to login.

For spring.security.oauth2 I used the following settings:

spring.security.oauth2.client.registration.gitlab.client-id=[client-id]" 
spring.security.oauth2.client.registration.gitlab.client-secret=[client-secret]
spring.security.oauth2.client.registration.gitlab.authorization-grant-type=authorization_code
spring.security.oauth2.client.registration.gitlab.redirect-uri=http://[openvsx-host-name]/login/oauth2/code/gitlab
spring.security.oauth2.client.registration.gitlab.scope=read_user
spring.security.oauth2.client.registration.gitlab.clientName=OpenVSX
spring.security.oauth2.client.provider.gitlab.authorization-uri=http://[gitlab-host-name]/oauth/authorize
spring.security.oauth2.client.provider.gitlab.token-uri=http://[gitlab-host-name]/oauth/token
spring.security.oauth2.client.provider.gitlab.user-info-uri=http://[gitlab-host-name]/api/v4/user
spring.security.oauth2.client.provider.gitlab.jwk-set-uri=http://[gitlab-host-name]/oauth/discovery/keys
spring.security.oauth2.client.provider.gitlab.user-name-attribute=id

HeikoBoettger-KarlStorz · 2024-12-12T12:25:01Z

For completeness this is the configuration inside gitlab:

paul-marechal · 2024-12-13T14:27:53Z

I noticed that there's another PR opened which allows to auth users without oauth2, so I renamed the configuration I introduced from ovsx.auth to ovsx.oauth2 so it better match its intended purpose.

I also updated the main PR description with a configuration example I took from @HeikoBoettger-KarlStorz :)

HeikoBoettger-KarlStorz · 2025-01-23T06:34:32Z

@amvanbaren Anything still missing to get this released? I can confirm this is working with both microsoft entra/azure sso (using a corporate tenant) and gitlab.

amvanbaren · 2025-02-26T14:27:48Z

I think this feature is ready to go.
@HeikoBoettger-KarlStorz Can you do a final test with both microsoft entra/azure sso (using a corporate tenant) and gitlab?

HeikoBoettger-KarlStorz · 2025-02-26T17:11:29Z

@amvanbaren Yes, I will test it tomorrow morning.

HeikoBoettger-KarlStorz · 2025-02-27T18:30:40Z

@amvanbaren Do you some more information on what has changed according to the /login end-point. I see that ther was a change to /login-providers but I that end-point now says that there are no login providers.

amvanbaren · 2025-02-27T18:38:34Z

@HeikoBoettger-KarlStorz The /login-providers endpoint returns registered clients with an attribute configuration:

openvsx/server/src/main/java/org/eclipse/openvsx/UserService.java

Lines 326 to 336 in f9771a7

    
               public Map<String, String> getLoginProviders() { 
        
                   if(clientRegistrationRepository == null) { 
        
                       return Collections.emptyMap(); 
        
                   } 
        
                   return attributesConfig.getProviders().stream() 
        
                           .filter(provider -> clientRegistrationRepository.findByRegistrationId(provider) != null) 
        
                           .map(provider -> Map.entry(provider, UrlUtil.createApiUrl(UrlUtil.getBaseUrl(), "oauth2", "authorization", provider))) 
        
                           .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)); 
        
               } 
        
           }

HeikoBoettger-KarlStorz · 2025-02-28T09:14:41Z

I used in the generate-properties.sh for testing, but I the gitlab config isn't read into the attributeConfigs:

echo "ovsx.auth2.attribute-names.gitlab.avatar-url=avatar_url" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.email=email" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.full-name=name" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.login-name=username" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.provider-url=html_url" >> $OVSX_APP_PROFILE

Any guess what I am doing wrong?

HeikoBoettger-KarlStorz · 2025-03-04T13:58:24Z

I used in the generate-properties.sh for testing, but I the gitlab config isn't read into the attributeConfigs:

echo "ovsx.auth2.attribute-names.gitlab.avatar-url=avatar_url" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.email=email" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.full-name=name" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.login-name=username" >> $OVSX_APP_PROFILE
echo "ovsx.auth2.attribute-names.gitlab.provider-url=html_url" >> $OVSX_APP_PROFILE

Any guess what I am doing wrong?

Missed the o, must be ovsx.oauth2 but I still get an error that no authentication request is found when the gitlab server invokes the login/oauth2/code/gitlab end-point.

HeikoBoettger-KarlStorz · 2025-03-05T10:04:38Z

@amvanbaren Is there a description somewhere about testing the oauth2-stuff? For oauth2 the server needs to be reached by the same hostname and port during the whole login process otherwise the session cookie isn't working. I didn't had the x-forwarded-host and x-forwarded-proto headers set correctly in the reverse-proxy of my local install. I am not sure why this suddenly turned out to be an issue with my test setup.

I can confirm the login with gitlab still works.

HeikoBoettger-KarlStorz · 2025-03-05T14:23:16Z

@amvanbaren Is the usage of the x-forward-headers something new, I found an explicit comment in my code, that setting the headers didn't had any effect and now it does.

I can confirm the microsoft login is working as well.

HeikoBoettger-KarlStorz · 2025-03-05T14:30:12Z

@amvanbaren I haven't tried with multiple providers at once due to other tasks on my end. If needed I will do so as well. Please let me know.

nfogh · 2025-03-10T10:25:34Z

Hi. I'm trying to get this branch to work for a local deployment (very excited about it - thanks for the work). But I'm getting an error when launching the server:

org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'extensionService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/ExtensionService.class]: Unsatisfied dependency expressed through constructor parameter 3: Error creating bean with name 'publishExtensionVersionHandler' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'userService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/UserService.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception with message: authorizationGrantType cannot be null

I'm using the docker-compose file to start

docker-compose --profile debug --profile openvsx up

Any idea what I am missing?

I have set authorization-grant-type in my application.yml file:

spring:
  security:
    oauth2:
      client:
        registration:
          gitlab:
            client-id: [redacted]
            client-secret: [redacted]
            authorization-grant-type: authorization_code
            redirect-uri: http://[webui-host]:3000/login/oauth2/code/gitlab
            scope: read_user
            clientName: OpenVSX
        provider:
          gitlab:
            authorization-uri: https://[gitlab-host]/oauth/authorize
            token-uri: https://[gitlab-host]/oauth/token
            user-info-uri: https://[gitlab-host]/api/v4/user
            jwk-set-uri: https://[gitlab-host]/oauth/discovery/keys
            user-name-attribute: id

  oauth2:
    provider: gitlab
    attribute-names:
      gitlab:
        avatar-url: avatar_url
        email: email
        full-name: name
        login-name: username
        provider-url: ''

amvanbaren · 2025-03-10T12:20:15Z

@HeikoBoettger-KarlStorz No, that's ok. The only difference for multiple providers is that it shows a dialog with login buttons in the webui.

- Replace the references to `OAuth2User` by `AuthUser`. This allows downstream extenders to more easily contribute alternative OAuth2 providers: If the expected data is stored in different attributes it will be possible to bridge it by implementing the proper `AuthUser`. - Introduce a configuration to define attribute names to use when mapping attributes from an auth provider. - Allow configuring the auth for arbitrary providers (other than github). - Add support for multiple login providers in webui Co-authored-by: amvanbaren <aart.vanbaren@eclipse-foundation.org>

HeikoBoettger-KarlStorz · 2025-03-10T15:32:25Z

@amvanbaren Thank you for merging and bringing this into the master.

HeikoBoettger · 2025-03-14T20:50:47Z

Hi Nikolaj, I saw that there wasn’t yet an answer. Unless you just missed copying the right parts, the second part doesn’t work when put under spring, it must be under ovsx. Otherwise the question is whether you have actually changed the scripts/generate-properties.sh script or the compose-file because as far as I know that would generate and overwrite the application-property file to be used on every start. Since this is merged now, have you checked with latest release? Von: Nikolaj Fogh ***@***.***> Gesendet: Montag, 10. März 2025 11:26 An: eclipse/openvsx ***@***.***> Cc: HeikoBoettger ***@***.***>; Mention ***@***.***> Betreff: Re: [eclipse/openvsx] server: refactor: introduce `AuthUser` interface (PR #838) Hi. I'm trying to get this branch to work for a local deployment (very excited about it - thanks for the work). But I'm getting an error when launching the server: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'extensionService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/ExtensionService.class]: Unsatisfied dependency expressed through constructor parameter 3: Error creating bean with name 'publishExtensionVersionHandler' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'userService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/UserService.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception with message: authorizationGrantType cannot be null I'm using the docker-compose file to start docker-compose --profile debug --profile openvsx up Any idea what I am missing? I have set authorization-grant-type in my application.yml file: spring: security: oauth2: client: registration: gitlab: client-id: [redacted] client-secret: [redacted] authorization-grant-type: authorization_code redirect-uri: http://[webui-host]:3000/login/oauth2/code/gitlab scope: read_user clientName: OpenVSX provider: gitlab: authorization-uri: https://[gitlab-host]/oauth/authorize token-uri: https://[gitlab-host]/oauth/token user-info-uri: https://[gitlab-host]/api/v4/user jwk-set-uri: https://[gitlab-host]/oauth/discovery/keys user-name-attribute: id oauth2: provider: gitlab attribute-names: gitlab: avatar-url: avatar_url email: email full-name: name login-name: username provider-url: '' — Reply to this email directly, view it on GitHub <#838 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFA3BRRA33AOOJLJNH5GJAD2TVSDJAVCNFSM6AAAAABTEVL2QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGA4TMOBQG4> . You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AFA3BRWRTI76FUK2Y55F2GD2TVSDJA5CNFSM6AAAAABTEVL2QKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVBRDF2O.gif> Message ID: ***@***.*** ***@***.***> > <https://avatars.githubusercontent.com/u/17196968?s=20&v=4> nfogh left a comment (eclipse/openvsx#838) <#838 (comment)> Hi. I'm trying to get this branch to work for a local deployment (very excited about it - thanks for the work). But I'm getting an error when launching the server: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'extensionService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/ExtensionService.class]: Unsatisfied dependency expressed through constructor parameter 3: Error creating bean with name 'publishExtensionVersionHandler' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'userService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/UserService.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception with message: authorizationGrantType cannot be null I'm using the docker-compose file to start docker-compose --profile debug --profile openvsx up Any idea what I am missing? I have set authorization-grant-type in my application.yml file: spring: security: oauth2: client: registration: gitlab: client-id: [redacted] client-secret: [redacted] authorization-grant-type: authorization_code redirect-uri: http://[webui-host]:3000/login/oauth2/code/gitlab scope: read_user clientName: OpenVSX provider: gitlab: authorization-uri: https://[gitlab-host]/oauth/authorize token-uri: https://[gitlab-host]/oauth/token user-info-uri: https://[gitlab-host]/api/v4/user jwk-set-uri: https://[gitlab-host]/oauth/discovery/keys user-name-attribute: id oauth2: provider: gitlab attribute-names: gitlab: avatar-url: avatar_url email: email full-name: name login-name: username provider-url: '' — Reply to this email directly, view it on GitHub <#838 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFA3BRRA33AOOJLJNH5GJAD2TVSDJAVCNFSM6AAAAABTEVL2QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGA4TMOBQG4> . You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AFA3BRWRTI76FUK2Y55F2GD2TVSDJA5CNFSM6AAAAABTEVL2QKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVBRDF2O.gif> Message ID: ***@***.*** ***@***.***> >

nfogh · 2025-03-15T08:49:35Z

Hi Nikolaj, I saw that there wasn’t yet an answer. Unless you just missed copying the right parts, the second part doesn’t work when put under spring, it must be under ovsx. Otherwise the question is whether you have actually changed the scripts/generate-properties.sh script or the compose-file because as far as I know that would generate and overwrite the application-property file to be used on every start. Since this is merged now, have you checked with latest release? Von: Nikolaj Fogh @.> Gesendet: Montag, 10. März 2025 11:26 An: eclipse/openvsx @.> Cc: HeikoBoettger @.>; Mention @.> Betreff: Re: [eclipse/openvsx] server: refactor: introduce AuthUser interface (PR #838) Hi. I'm trying to get this branch to work for a local deployment (very excited about it - thanks for the work). But I'm getting an error when launching the server: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'extensionService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/ExtensionService.class]: Unsatisfied dependency expressed through constructor parameter 3: Error creating bean with name 'publishExtensionVersionHandler' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'userService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/UserService.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception with message: authorizationGrantType cannot be null I'm using the docker-compose file to start docker-compose --profile debug --profile openvsx up Any idea what I am missing? I have set authorization-grant-type in my application.yml file: spring: security: oauth2: client: registration: gitlab: client-id: [redacted] client-secret: [redacted] authorization-grant-type: authorization_code redirect-uri: http://[webui-host]:3000/login/oauth2/code/gitlab scope: read_user clientName: OpenVSX provider: gitlab: authorization-uri: https://[gitlab-host]/oauth/authorize token-uri: https://[gitlab-host]/oauth/token user-info-uri: https://[gitlab-host]/api/v4/user jwk-set-uri: https://[gitlab-host]/oauth/discovery/keys user-name-attribute: id oauth2: provider: gitlab attribute-names: gitlab: avatar-url: avatar_url email: email full-name: name login-name: username provider-url: '' — Reply to this email directly, view it on GitHub <#838 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFA3BRRA33AOOJLJNH5GJAD2TVSDJAVCNFSM6AAAAABTEVL2QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGA4TMOBQG4 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AFA3BRWRTI76FUK2Y55F2GD2TVSDJA5CNFSM6AAAAABTEVL2QKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVBRDF2O.gif Message ID: @.*** @.> > https://avatars.githubusercontent.com/u/17196968?s=20&v=4 nfogh left a comment (eclipse/openvsx#838) <#838 (comment)> Hi. I'm trying to get this branch to work for a local deployment (very excited about it - thanks for the work). But I'm getting an error when launching the server: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'extensionService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/ExtensionService.class]: Unsatisfied dependency expressed through constructor parameter 3: Error creating bean with name 'publishExtensionVersionHandler' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'userService' defined in file [/app/build/classes/java/main/org/eclipse/openvsx/UserService.class]: Unsatisfied dependency expressed through constructor parameter 5: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception with message: authorizationGrantType cannot be null I'm using the docker-compose file to start docker-compose --profile debug --profile openvsx up Any idea what I am missing? I have set authorization-grant-type in my application.yml file: spring: security: oauth2: client: registration: gitlab: client-id: [redacted] client-secret: [redacted] authorization-grant-type: authorization_code redirect-uri: http://[webui-host]:3000/login/oauth2/code/gitlab scope: read_user clientName: OpenVSX provider: gitlab: authorization-uri: https://[gitlab-host]/oauth/authorize token-uri: https://[gitlab-host]/oauth/token user-info-uri: https://[gitlab-host]/api/v4/user jwk-set-uri: https://[gitlab-host]/oauth/discovery/keys user-name-attribute: id oauth2: provider: gitlab attribute-names: gitlab: avatar-url: avatar_url email: email full-name: name login-name: username provider-url: '' — Reply to this email directly, view it on GitHub <#838 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFA3BRRA33AOOJLJNH5GJAD2TVSDJAVCNFSM6AAAAABTEVL2QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGA4TMOBQG4 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AFA3BRWRTI76FUK2Y55F2GD2TVSDJA5CNFSM6AAAAABTEVL2QKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVBRDF2O.gif Message ID: @. @.***> >

Hi

I tried with the latest release, and it works great there. It might have had something to do with the scripts you refer to.

Thanks for following up on my message. Since the MR was closed, i didn't think anyone was paying attention :)

HeikoBoettger suggested changes Feb 29, 2024

View reviewed changes

server/src/main/java/org/eclipse/openvsx/security/DefaultAuthUser.java Outdated Show resolved Hide resolved

paul-marechal force-pushed the auth-user branch from bc4fb47 to 0f8c930 Compare March 1, 2024 18:56

paul-marechal commented Mar 4, 2024

View reviewed changes

server/src/main/java/org/eclipse/openvsx/security/AuthUserFactory.java Outdated Show resolved Hide resolved

HeikoBoettger mentioned this pull request Apr 28, 2024

Support for additional Identity/Login Providers? #337

Closed

paul-marechal force-pushed the auth-user branch from 8f65be8 to 0e07da9 Compare December 9, 2024 14:41

paul-marechal commented Dec 11, 2024

View reviewed changes

server/src/main/java/org/eclipse/openvsx/security/OAuth2UserServices.java Outdated Show resolved Hide resolved

amvanbaren self-assigned this Feb 20, 2025

amvanbaren force-pushed the auth-user branch 4 times, most recently from 38601f7 to 95e22e0 Compare February 26, 2025 14:14

amvanbaren force-pushed the auth-user branch from 95e22e0 to f9771a7 Compare February 27, 2025 17:47

amvanbaren linked an issue Feb 27, 2025 that may be closed by this pull request

Support for additional Identity/Login Providers? #337

Closed

amvanbaren force-pushed the auth-user branch from f9771a7 to 56d1849 Compare March 10, 2025 12:54

amvanbaren merged commit 56a500e into eclipse:master Mar 10, 2025
2 checks passed

github-project-automation bot moved this from In Progress to Done in Eclipse Open VSX Mar 10, 2025

amvanbaren mentioned this pull request Mar 11, 2025

Release v0.23.1 EclipseFdn/open-vsx.org#3574

Merged

paul-marechal deleted the auth-user branch April 5, 2025 22:01

netomi mentioned this pull request Nov 5, 2025

Syncing profile details from Github #1075

Closed

Conversation

paul-marechal commented Nov 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paul-marechal commented Nov 25, 2023

Uh oh!

Uh oh!

paul-marechal commented Mar 1, 2024

Uh oh!

Uh oh!

amvanbaren commented Apr 29, 2024

Uh oh!

HeikoBoettger-KarlStorz commented Dec 6, 2024

Uh oh!

HeikoBoettger-KarlStorz commented Dec 6, 2024

Uh oh!

amvanbaren commented Dec 9, 2024

Uh oh!

paul-marechal commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amvanbaren commented Dec 10, 2024

Uh oh!

paul-marechal commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amvanbaren commented Dec 10, 2024

Uh oh!

paul-marechal commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paul-marechal commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HeikoBoettger-KarlStorz commented Dec 11, 2024

Uh oh!

paul-marechal commented Dec 11, 2024

Uh oh!

Uh oh!

HeikoBoettger-KarlStorz commented Dec 12, 2024

Uh oh!

HeikoBoettger-KarlStorz commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HeikoBoettger-KarlStorz commented Dec 12, 2024

Uh oh!

paul-marechal commented Dec 13, 2024

Uh oh!

HeikoBoettger-KarlStorz commented Jan 23, 2025

Uh oh!

amvanbaren commented Feb 26, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Feb 26, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Feb 27, 2025

Uh oh!

amvanbaren commented Feb 27, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Feb 28, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Mar 4, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Mar 5, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Mar 5, 2025

Uh oh!

HeikoBoettger-KarlStorz commented Mar 5, 2025

Uh oh!

nfogh commented Mar 10, 2025

Uh oh!

amvanbaren commented Mar 10, 2025

Uh oh!

Uh oh!

HeikoBoettger-KarlStorz commented Mar 10, 2025

Uh oh!

HeikoBoettger commented Mar 14, 2025 via email

Uh oh!

nfogh commented Mar 15, 2025

Uh oh!

Reviewers

paul-marechal commented Nov 25, 2023 •

edited

Loading

paul-marechal commented Dec 9, 2024 •

edited

Loading

paul-marechal commented Dec 10, 2024 •

edited

Loading

paul-marechal commented Dec 10, 2024 •

edited

Loading

paul-marechal commented Dec 10, 2024 •

edited

Loading

HeikoBoettger-KarlStorz commented Dec 12, 2024 •

edited

Loading