Skip to content

[Diff] sbAsma/issue1279 noise conditioning #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatKbauer merged 15 commits into from
Jan 23, 2026
Merged

[Diff] sbAsma/issue1279 noise conditioning #1358

Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6b90581
initial commit [draft]
moritzhauschulz Nov 17, 2025
07d45d6
adapt noise conditioner to make it closer to DiT
moritzhauschulz Nov 18, 2025
8a91014
adapt dimensionalities – code runs with default config
moritzhauschulz Nov 23, 2025
9d02a73
lint
moritzhauschulz Nov 23, 2025
7701a9e
fix: add conditional prediction mode handling
sbAsma Nov 26, 2025
c65ad7b
added forecast engine argument
sbAsma Nov 26, 2025
ddc820d
merged mk/develop/1300_assemble_diffusion_model
sbAsma Nov 27, 2025
9137b81
removed unecessary logging
sbAsma Nov 27, 2025
0db09af
reverting back to the previous config
sbAsma Nov 28, 2025
18c63fa
Merge branch 'mk/develop/1300_assemble_diffusion_model' into sbAsma/i…
sbAsma Nov 28, 2025
45e94cd
replaced getattr by get
sbAsma Dec 1, 2025
5c2bb02
Merge branch 'sbAsma/issue1279_noise_conditioning' of https://github.…
sbAsma Dec 1, 2025
f9fcad5
resolving conflict
sbAsma Dec 1, 2025
bfeeacb
modification of forecasting engine initialization
sbAsma Jan 13, 2026
e006823
Merge branch 'mk/develop/1300_assemble_diffusion_model' into sbAsma/i…
MatKbauer Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/weathergen/model/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,9 +334,16 @@ def create(self) -> "Model":
"Empty forecast engine (fe_num_blocks = 0), but forecast_steps[i] > 0 for some i"
)

self.forecast_engine = ForecastingEngine(cf, self.num_healpix_cells)
if cf.fe_diffusion_model:
# check if diffusion mode is enabled
fe_diffusion_model = cf.get("fe_diffusion_model", False)
if fe_diffusion_model:
self.forecast_engine = DiffusionForecastEngine(
forecast_engine=ForecastingEngine(
cf, self.num_healpix_cells, forecast_engine=self.forecast_engine
)
)
else:
self.forecast_engine = ForecastingEngine(
cf, self.num_healpix_cells, forecast_engine=self.forecast_engine
)
Copy link
Contributor

@MatKbauer MatKbauer Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking long to inspect this. Can we please change the above code to

        self.forecast_engine = ForecastingEngine(cf, self.num_healpix_cells)
        if cf.get("fe_diffusion_model", False):
            self.forecast_engine = DiffusionForecastEngine(
                forecast_engine=ForecastingEngine(
                     cf, self.num_healpix_cells, forecast_engine=self.forecast_engine
                )
            )

Then we will first create the deterministic forecast engine (which we will need in any case) and optionally wrap it by the diffusion engine.

Copy link
Contributor Author

@sbAsma sbAsma Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)


Expand Down