Skip to content

Conversation

@ankitpatnala
Copy link
Contributor

@ankitpatnala ankitpatnala commented Dec 17, 2025

Description

Issue Number

Closes #1479

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@ankitpatnala ankitpatnala marked this pull request as draft December 17, 2025 14:18
@ankitpatnala ankitpatnala changed the base branch from develop to main December 17, 2025 14:19
@ankitpatnala
Copy link
Contributor Author

@grassesi

@ankitpatnala ankitpatnala changed the title Ankit add epoch to the training plot ( by default takes -1 otherwise take the user-defined epoch number) Add epoch to the training plot ( by default takes -1 otherwise take the user-defined epoch number) Dec 17, 2025
@@ -0,0 +1,35 @@
train :
plot :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to commit these configs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not big of a change but doesn't affect anything in terms of functionality of code? I feel I (maybe others) may need it later also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants