Skip to content

Conversation

@sophie-xhonneux
Copy link
Contributor

Description

Generate with an AI coding agent, verified by human

Issue Number

Closes #1599

Is this PR a draft? Mark it as draft.

@clessig
Copy link
Collaborator

clessig commented Jan 14, 2026

Super, thanks! I will make a pass through it in the next days.

| `start_date` | datetime | `1979-01-01T00:00` | Training data start date |
| `end_date` | datetime | `2022-12-31T00:00` | Training data end date |
| `time_window_step` | duration | `06:00:00` | Time step between windows |
| `time_window_len` | duration | `06:00:00` | Length of each time window |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing type from "duration" to "timedelta". I think it's better to use name already known from pandas or numpy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to edit it! I am open

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to but I don't have write access to this repo. Can I open PR into your branch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please open a PR against this one.

| `fe_layer_norm_after_blocks` | list | `[]` | Block indices after which to add LayerNorm (0-indexed) |
| `fe_impute_latent_noise_std` | float | `0.0` | Standard deviation for latent noise imputation |
| `forecast_att_dense_rate` | float | `1.0` | Precentage of attention layers that are dense |
| `with_step_conditioning` | bool | `True` | Enable step conditioning in forecast engine |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with_step_conditioning can be removed. I will submit a commit change


| Parameter | Type | Default | Options | Description |
|-----------|------|---------|---------|-------------|
| `time_step` | timedelta | `06:00:00` | | Time step between forecast steps |
Copy link
Contributor

@SavvasMel SavvasMel Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I got a bit confused about having "time step between", would it capture it better if we write:

"(Fixed) Time interval between consecutive forecast steps"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to commit so if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Document the config [INITIAL SETUP]

5 participants