Skip to content

Conversation

@b8raoult
Copy link
Collaborator

@b8raoult b8raoult commented May 12, 2025

Description

This PR revisits the accumulation source to extend it to work with other backends apart from MARS. As part of this work the main outcomes and changes are:

  • Interface change: Accumulation source is now named 'accumulate' and can work with both MARS and GRIB files. This new source takes 4 inputs: source, availability, patch and period.
  • PR includes docs with more details on the above docs/building/sources/accumulate.rst and a recipe example docs/howtos/create/05-create-accumulations.rst

Future work will be done to extend this source to work with other backends. The new design will make this much easier as new backends will be easier to simply plug to the source.


📚 Documentation preview 📚: https://anemoi-datasets--326.org.readthedocs.build/en/326/

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels May 12, 2025
@flyIchtus flyIchtus changed the title Feat/abstracting accumulation feat/abstracting accumulation May 16, 2025
@flyIchtus flyIchtus changed the title feat/abstracting accumulation feat: abstracting accumulation May 16, 2025
@flyIchtus flyIchtus marked this pull request as ready for review May 16, 2025 16:41
@github-actions github-actions bot added the tests label May 23, 2025
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev May 23, 2025
@floriankrb floriankrb force-pushed the feat/abstracting_accumulation branch from 0c78564 to abd784d Compare January 16, 2026 10:15
@floriankrb
Copy link
Member

This PR is finished from my point of view and could be merged.

Many additional tests have been added and all relevant tests are passing. The API changes slightly and is documented. Another PR will be required to handle other sources and/or compute running averages, as this may lead to changing the argument passed to the sources and needs to be coordinated with the current work on observations.

@flyIchtus ?

@MeraX
Copy link
Contributor

MeraX commented Jan 16, 2026

Please update the description before merging.

I mean description of this PR to get a helpful commit message.

@anaprietonem
Copy link
Contributor

Please update the description before merging.

I mean description of this PR to get a helpful commit message.

Hey @MeraX description is now updated!

@anaprietonem anaprietonem self-requested a review January 21, 2026 14:46
@anaprietonem anaprietonem merged commit 57a2895 into main Jan 22, 2026
70 checks passed
@anaprietonem anaprietonem deleted the feat/abstracting_accumulation branch January 22, 2026 11:23
@github-project-automation github-project-automation bot moved this from Now In Progress to Done in Anemoi-dev Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS approved bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.