-
Notifications
You must be signed in to change notification settings - Fork 54
Observations feature branch #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o feat/recipe-generator
…o feat/recipe-generator
…t/move-code-to-prepare-for-observations
|
Hi @b8raoult, as I mentioned during the MLPP meeting I was wondering if |
| "grid_definition": { | ||
| "icon": { | ||
| "path": gridfile, | ||
| "refinement_level_c": input_refinement_level_c, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "refinement_level_c": input_refinement_level_c, | |
| "refinement_level_c": None, |
From @MeraX
Thanks for fixing this inconsistency. I think in general there is no need to set refinement_level_c for the icon grid_definition as the grid must always correspond to the grib data. Thus I would make the following suggestion:
If I understood the earthkit team correctly, they are working on supporting ICON grids. I.e. it will be possible to ask EKD for the grid definition, making the icon grid_definition in anemoi-datatests unnecessary.
Planned medium-term feature branch to enable the development of observation dataset training.
Key components:
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.