Conversation
github-actions
bot
added
dependencies
| The name of the grid | ||
| id : str | list[float] | tuple[float, float] | ||
| The identifier of the grid, either a string like "o96" or a tuple/list | ||
| of two numbers (describing the resolution). |
There was a problem hiding this comment.
For info: renamed function and added more info to docstring
There was a problem hiding this comment.
id is a bad argument name, because it is a python built-in function, I propose grid_id.
There was a problem hiding this comment.
Changed to grid_id. Thanks!
yoel-zerah
left a comment
yoel-zerah
left a comment
There was a problem hiding this comment.
(From #108) In tests/test_regrid.py, in test_make_regrid_mask the size of the mask produced by global-on-lam-mask is checked against a reference provided in "anemoi-transform/filters/regrid/ea-over-rr-mask.npz".
Unfortunately, this reference mask has the wrong shape: the mask tested is generated by cropping ERA5 to CERRA (under 38k grid points), but the reference mask contains all of the original 542k ERA5 grid points.
- How can we change the provided mask with another file ?
- How do we generate a new reference file ? At the moment the only way I can generate a mask is with this feature being tested...
Should this be fixed or removed ?
github-project-automation
bot
moved this from To be triaged
to Under Review
in Anemoi-dev
|
@yoel-zerah It should now be fixed (but doesn't require a code change) |
|
|
||
|
|
||
| @skip_if_offline | ||
| @pytest.mark.slow |
There was a problem hiding this comment.
where are we using this? as in do those run then at PR level, nightly or which is the frequency?
There was a problem hiding this comment.
By default we won't be running them in the CI, which is as the same as in anemoi-datasets. I run these locally before pushing up a PR (as with datasets)
anaprietonem
left a comment
anaprietonem
left a comment
There was a problem hiding this comment.
Left some minor comments mostly for clarify
anaprietonem
left a comment
anaprietonem
left a comment
There was a problem hiding this comment.
Thanks for addressing my comment, LGTM
|
Thank you! |
3 participants
Implement outstanding review comments on #108