Skip to content

fix: grouping key changed to frozenset#239

Merged
aaron-hopkinson merged 1 commit intomainfrom
fix/groupby_key_ordering
Feb 24, 2026
Merged

fix: grouping key changed to frozenset#239
aaron-hopkinson merged 1 commit intomainfrom
fix/groupby_key_ordering

Conversation

@aaron-hopkinson
Copy link
Contributor

Description

Grouping key changed from tuple to frozenset (used by matching filters).

What problem does this change solve?

Grouping keys should be independent of ordering - conversion to frozenset fixes this.

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@aaron-hopkinson aaron-hopkinson self-assigned this Feb 24, 2026
@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Feb 24, 2026
@github-actions github-actions bot added the bug Something isn't working label Feb 24, 2026
Copy link
Member

@HCookie HCookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from To be triaged to For merging in Anemoi-dev Feb 24, 2026
@aaron-hopkinson aaron-hopkinson merged commit 7a5b427 into main Feb 24, 2026
193 of 195 checks passed
@github-project-automation github-project-automation bot moved this from For merging to Done in Anemoi-dev Feb 24, 2026
@aaron-hopkinson aaron-hopkinson deleted the fix/groupby_key_ordering branch February 24, 2026 16:08
aaron-hopkinson pushed a commit that referenced this pull request Feb 27, 2026
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


##
[0.1.27](0.1.26...0.1.27)
(2026-02-26)


### Features

* Add `return_distances` option to nearest grid point lookup function
([#237](#237))
([c1d3133](c1d3133))
* Import tabular filters
([#216](#216))
([548e2fa](548e2fa))


### Bug Fixes

* Grouping key changed to frozenset
([#239](#239))
([7a5b427](7a5b427))

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS Approval not needed bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants