Skip to content

refactor: matching/grouping keys into separate method #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-hopkinson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: matching/grouping keys into separate method #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a3699
refactor grouping keys into separate method
aaron-hopkinson Feb 20, 2026
570528e
Merge branch 'main' into refactor/grouping_keys
aaron-hopkinson Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions src/anemoi/transform/grouping/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,33 @@ def __init__(self, params: list[str]) -> None:
params = [params]
self.params = _flatten(params)

@staticmethod
def _get_grouping_key(field, extract_keys: list[str] | None = None, remove_from_key: list[str] | None = None):
key = field.metadata(namespace="mars")
if not key:
keys = [k for k in field.metadata().keys() if k not in ("latitudes", "longitudes", "values")]
key = {k: field.metadata(k) for k in keys}
if not keys:
raise NotImplementedError(f"GroupByParam: {field} has no sufficient metadata")

extract = {}
for k in extract_keys:
extract[k] = key.pop(k, field.metadata().get(k, default=None))

for k in remove_from_key:
key.pop(k, None)

if len(extract) != len(extract_keys):
raise ValueError(f"Expected {extract_keys} keys to extract, got {extract}")
return key, extract

def _get_groups(self, data: list[Any], *, other: Callable[[Any], None] = _lost) -> None:
assert callable(other), type(other)
self.groups: dict[tuple[tuple[str, Any], ...], dict[str, Any]] = defaultdict(dict)
self.groups_params = set()
for f in data:
key = f.metadata(namespace="mars")
if not key:
keys = [k for k in f.metadata().keys() if k not in ("latitudes", "longitudes", "values")]
key = {k: f.metadata(k) for k in keys}
if not keys:
raise NotImplementedError(f"GroupByParam: {f} has no sufficient metadata")

param = key.pop("param", f.metadata("param"))
key.pop("variable", f.metadata("param"))
key, extras = self._get_grouping_key(f, extract_keys=["param"], remove_from_key=["variable"])
param = extras["param"]

if param not in self.params:
other(f)
Expand Down Expand Up @@ -125,18 +138,11 @@ def _get_groups(self, data: list[Any], *, other: Callable[[Any], None] = _lost)
self.groups_params = set()
levels: dict[str, Any] = defaultdict(list)
for f in data:
key = f.metadata(namespace="mars")
if not key:
keys = [k for k in f.metadata().keys() if k not in ("latitudes", "longitudes", "values")]
key = {k: f.metadata(k) for k in keys}
if not keys:
raise NotImplementedError(f"GroupByParam: {f} has no sufficient metadata")

param = key.pop("param", f.metadata("param"))
key.pop("variable", None)

_ = key.pop("levtype", None)
level = key.pop("levelist", None)
key, extras = self._get_grouping_key(
f, extract_keys=["param", "levelist"], remove_from_key=["variable", "levtype"]
)
param = extras["param"]
level = extras["levelist"]

if param not in self.params:
other(f)
Expand Down
Loading