Skip to content

Do not use eckit Grid.spec for gridspecs#891

Merged
sandorkertesz merged 1 commit intodevelopfrom
fix/do-not-use-eckit-geo-spec-method
Feb 5, 2026
Merged

Do not use eckit Grid.spec for gridspecs#891
sandorkertesz merged 1 commit intodevelopfrom
fix/do-not-use-eckit-geo-spec-method

Conversation

@sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented Feb 5, 2026

Description

In the experimental geography code using eckit.geo.Grid.spec is disabled since it does not seem to work in the version used.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (a5a18c3) to head (c694e86).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #891      +/-   ##
===========================================
+ Coverage    85.35%   85.36%   +0.01%     
===========================================
  Files          184      184              
  Lines        14562    14573      +11     
  Branches       732      732              
===========================================
+ Hits         12429    12440      +11     
  Misses        1922     1922              
  Partials       211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz sandorkertesz merged commit 891e2e5 into develop Feb 5, 2026
112 of 118 checks passed
@sandorkertesz sandorkertesz deleted the fix/do-not-use-eckit-geo-spec-method branch February 5, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants