Semantics of xr-engine decode_timedelta kwarg fixed#901
Merged
sandorkertesz merged 3 commits intodevelopfrom Feb 18, 2026
Merged
Semantics of xr-engine decode_timedelta kwarg fixed#901sandorkertesz merged 3 commits intodevelopfrom
sandorkertesz merged 3 commits intodevelopfrom
Conversation
Several tests adjusted accordingly
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #901 +/- ##
===========================================
- Coverage 85.36% 85.35% -0.01%
===========================================
Files 184 184
Lines 14573 14564 -9
Branches 732 723 -9
===========================================
- Hits 12440 12431 -9
Misses 1922 1922
Partials 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
decode_timedeltakwargs will conform to the docstring in the xr-engine method.to_xarray():If the coordinate
stephasintorstrvalues (e.g. when issued from the GRIB keystep) anddecode_timedelta=True, then a conversion totimedeltais applied. In other cases thestepcoordinate remain unchanged (either asintortimedelta, if it was issued from thestep_timedeltakey)Several xr-engine tests were adjusted or corrected to accomodate this change.
Also, the coordinate comparison test (in xr-engine tests) was fixed.
Contributor Declaration
By opening this pull request, I affirm the following: