Skip to content

Semantics of xr-engine decode_timedelta kwarg fixed#901

Merged
sandorkertesz merged 3 commits intodevelopfrom
fix/decode_timedelta
Feb 18, 2026
Merged

Semantics of xr-engine decode_timedelta kwarg fixed#901
sandorkertesz merged 3 commits intodevelopfrom
fix/decode_timedelta

Conversation

@pawel-wolff
Copy link
Contributor

Description

The decode_timedelta kwargs will conform to the docstring in the xr-engine method .to_xarray():
If the coordinate step has int or str values (e.g. when issued from the GRIB key step) and decode_timedelta=True, then a conversion to timedelta is applied. In other cases the step coordinate remain unchanged (either as int or timedelta, if it was issued from the step_timedelta key)

Several xr-engine tests were adjusted or corrected to accomodate this change.
Also, the coordinate comparison test (in xr-engine tests) was fixed.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

Several tests adjusted accordingly
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.35%. Comparing base (34b3656) to head (1397c9c).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #901      +/-   ##
===========================================
- Coverage    85.36%   85.35%   -0.01%     
===========================================
  Files          184      184              
  Lines        14573    14564       -9     
  Branches       732      723       -9     
===========================================
- Hits         12440    12431       -9     
  Misses        1922     1922              
  Partials       211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pawel-wolff added a commit that referenced this pull request Feb 18, 2026
@sandorkertesz sandorkertesz merged commit 921043c into develop Feb 18, 2026
107 checks passed
@sandorkertesz sandorkertesz deleted the fix/decode_timedelta branch February 18, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants