[cascade] add checkpoint persistence implementation #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmi
force-pushed
the
feat/scheduling/persist
branch
from
20274f1 to
33e4074
Compare
tmi
force-pushed
the
feat/scheduling/persist
branch
from
33e4074 to
4307e08
Compare
Member
|
I don't have full context to review this, however, I have no issue with merging |
tmi
force-pushed
the
feat/scheduling/persist
branch
from
4307e08 to
ce8829e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a few new message types between controller to executors -- DatasetPersistCommand, Success, Failure, ...
implements the "if dataset marked to be persisted, then:
1/ always publish it even fused
2/ dont purge if to be published
3/ once published for the first time, issue persist command
" etc
only single implementation of persist client for now -- locally mounted filesystem
a minor naming change in the gateway API -> best we merge this before we update fiab-ekw dependency
for the reviewer: probably just skim through this :) Lot of code but nothing surprising