Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #218 +/- ##
========================================
Coverage 73.38% 73.38%
========================================
Files 363 363
Lines 21956 21956
Branches 2255 2255
========================================
Hits 16113 16113
Misses 5843 5843 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tbkr
left a comment
There was a problem hiding this comment.
LGTM, left some small remarks.
| env: | ||
| REGISTRY: eccr.ecmwf.int | ||
| IMAGE_NAME: z3fdb-web-service | ||
| PROJECT_NAME: kkratz |
There was a problem hiding this comment.
Should this still be in this path or do we have a dmst project name?
There was a problem hiding this comment.
This will change later when we the service gets integrated.
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ secrets.KKRATZ_ECCR_USER }} |
There was a problem hiding this comment.
Those should probably also be the DMST/FDB_ECCR credentials?
There was a problem hiding this comment.
No, this will change later when the service gets integrated.
tbkr
left a comment
There was a problem hiding this comment.
Could you have a look at the failing CI?
da7b7e2 to
b2699af
Compare
Co-authored-by: Tobias Kremer <tobias.kremer@ecmwf.int>
b2699af to
ed8a96f
Compare
Description
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-218
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-218