Skip to content

Add z3fdb-web service#218

Open
Ozaq wants to merge 1 commit intodevelopfrom
z3fdb/climate-dt-on-lumi-databridge
Open

Add z3fdb-web service#218
Ozaq wants to merge 1 commit intodevelopfrom
z3fdb/climate-dt-on-lumi-databridge

Conversation

@Ozaq
Copy link
Member

@Ozaq Ozaq commented Feb 4, 2026

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-218

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-218

@Ozaq Ozaq requested a review from tbkr February 4, 2026 11:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.38%. Comparing base (b073f57) to head (ed8a96f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    73.38%   73.38%           
========================================
  Files          363      363           
  Lines        21956    21956           
  Branches      2255     2255           
========================================
  Hits         16113    16113           
  Misses        5843     5843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tbkr tbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some small remarks.

env:
REGISTRY: eccr.ecmwf.int
IMAGE_NAME: z3fdb-web-service
PROJECT_NAME: kkratz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be in this path or do we have a dmst project name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change later when we the service gets integrated.

uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ secrets.KKRATZ_ECCR_USER }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should probably also be the DMST/FDB_ECCR credentials?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will change later when the service gets integrated.

Copy link
Contributor

@tbkr tbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have a look at the failing CI?

@Ozaq Ozaq force-pushed the z3fdb/climate-dt-on-lumi-databridge branch 3 times, most recently from da7b7e2 to b2699af Compare February 13, 2026 11:41
@Ozaq Ozaq requested a review from tbkr February 13, 2026 11:42
Co-authored-by: Tobias Kremer <tobias.kremer@ecmwf.int>
@Ozaq Ozaq force-pushed the z3fdb/climate-dt-on-lumi-databridge branch from b2699af to ed8a96f Compare February 17, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants