Skip to content

Conversation

@joshkel
Copy link

@joshkel joshkel commented Oct 31, 2025

Fixes #556

This change is incompatible with ECharts pre 6.0.0.

Fixes ecomfe#556

This change is incompatible with ECharts pre 6.0.0.
@joshkel joshkel force-pushed the echarts-6-compatibility branch from 65ca32d to d694b96 Compare October 31, 2025 22:29
@ethannguyen276
Copy link

Hi, can we proritise this PR?

@ToppDev
Copy link

ToppDev commented Jan 15, 2026

Hey, I would also like this PR merged.

I tried this PR and ran into some issues described in lublak/typst-echarm-package#10 (comment) related to missing file extensions .js in the imports

just a repeat of the error:

✘ [ERROR] Could not resolve "zrender/lib/animation/Animator"

node_modules/echarts-gl/lib/util/animatableMixin.js:1:21:
  1 │ import Animator from 'zrender/lib/animation/Animator';
    ╵                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The module "./lib/animation/Animator" was not found on the file system:

node_modules/zrender/package.json:88:11:
  88 │     "./*": "./*"
     ╵            ~~~~~

Import from "zrender/lib/animation/Animator.js" to get the file
"node_modules/zrender/lib/animation/Animator.js":

node_modules/echarts-gl/lib/util/animatableMixin.js:1:52:
  1 │ import Animator from 'zrender/lib/animation/Animator';
    │                                                     ^
    ╵                                                     .js

You can mark the path "zrender/lib/animation/Animator" as external to exclude it from the bundle,
which will remove this error and leave the unresolved path in the bundle.

As I am not a professional in JS I am not sure if this is really an issue or I am too dumb to use npm. But maybe worth considering before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(feature request)support echarts 6.0

3 participants