Skip to content

新增Action中leave方法里调用Action.prototype.dispose #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenber wants to merge 2 commits into
base: 3.1/develop
Choose a base branch
from
Open

新增Action中leave方法里调用Action.prototype.dispose #164

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff0315
新增Action中leave方法里调用Action.prototype.dispose
wenber Aug 19, 2015
3d3afb0
修改er/Action dispose方法调用注释
wenber Sep 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Action.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,15 @@ define(
this.view = null;
}

/**
* 如果Action本身也有dispose方法，则执行
* 主要用来dispose掉一些DOM事就绑定，因为我们经常在Action中通过bindEvent来绑定DOM事件
Copy link
Member

@Justineo Justineo Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

绑定 DOM 事件为什么不是在 View 里做的？

Copy link
Member

@otakustay otakustay Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同意楼上，这个调用dispose的逻辑本身没问题，注释最好改改，太误导人

Copy link
Author

@wenber wenber Sep 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恩，注释改了

* 而destroyEvents只能dispose掉er事件
*/
if (typeof this.dispose === 'function') {
this.dispose();
}

/**
* @event leave
*
Expand Down