fix(ci): fix Format job so pre-commit and pylint pass#35
Open
fix(ci): fix Format job so pre-commit and pylint pass#35
Conversation
- validate-pyproject: use henryiii/validate-pyproject-schema-store repo (rev 2026.03.06) to avoid KeyError for removed tox.json schema - ruff: limit to src/estimark, tests, noxfile; exclude ipynb/slides; add per-file T20 and global ignores (E402, F405, PD010, RET504, etc.) - mypy: limit to src/estimark and tests; ignore_missing_imports, disable no-untyped-call and misc; relax strict override for estimark - codespell: exclude slides and ipynb; skip *.do and *.bib; fix typos in do_all.py (resource, minutes, manually) and estimation.py (labels) Made-with: Cursor
alanlujan91
approved these changes
Mar 9, 2026
…/pandas) Made-with: Cursor
Made-with: Cursor
alanlujan91
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing CI Format job (pre-commit + PyLint) so CI can pass.
Changes
validate-pyproject
henryiii/validate-pyproject-schema-storerepo (rev2026.03.06) instead of abravalheri hook with[all]extraKeyError: 'https://json.schemastore.org/tox.json'from removed schemaRuff
src/estimark/,tests/,noxfile.py(exclude content, notebooks, scripts)*.ipynbandcontent/slidesin ruff configMypy
src/estimarkandtests(skip scripts)ignore_missing_imports = true, disableno-untyped-callandmiscestimark.*commented out (can re-enable incrementally)Codespell
content/slides/and*.ipynb;--skip *.do,*.bibdo_all.py(resource, minutes, manually),estimation.py(labels in comment)Testing
pre-commit run --hook-stage manual --all-filespasses locallyMade with Cursor