Open
Conversation
Contributor
Author
|
Removing the CI restriction on |
econchick
reviewed
Oct 6, 2020
econchick
reviewed
Oct 6, 2020
s-weigand
force-pushed
the
remove-redundent-tests
branch
from
6a7d48a to
c3d911b
Compare
Since `black` is in your `.pre-commit-config.yaml`, having extra formatting tests is redundant + you would have to manage its version in two more places. As for running `pre-commit run -a` on the CI this is done by the 'Pre-commit' job, which utilizes caching.
s-weigand
force-pushed
the
remove-redundent-tests
branch
from
c3d911b to
52f8ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since
blackis in your.pre-commit-config.yaml, having extra formatting tests is redundant + you would have to manage its version in two more places.As for running
pre-commit run -alocally, this will be done on staged files by the installed hook.On the CIs 'Pre-commit' job all files will be tested and since it utilizes caching the tests should overall finish faster.
Motivation and Context
Failing CI tests du to check with an older version of
blacksee #54