Add Podman engine#160
Open
babykart wants to merge 5 commits intoedannenberg:masterfrom
babykart:master
Open
Conversation
edannenberg
requested changes
May 12, 2019
Owner
edannenberg
left a comment
There was a problem hiding this comment.
LGTM except for some minor stuff. 👍 No worries if you can't be bothered.
edannenberg
approved these changes
May 13, 2019
edannenberg
pushed a commit
that referenced
this pull request
May 13, 2019
edannenberg
added a commit
that referenced
this pull request
May 13, 2019
Owner
|
Squashed and merged. Thanks again! I'll leave this open until I get to update the docs for this. The |
Contributor
Author
|
A last commit, sorry. |
edannenberg
pushed a commit
that referenced
this pull request
May 14, 2019
Also adds an option to configure docker commit args.
Contributor
Author
|
With the last update on master, docker/podman commit fail with empty {DOCKER,PODMAN}_COMMIT_OPTS: "docker commit" requires at least 1 and at most 2 arguments. To fix it: diff --git a/engine/docker.sh b/engine/docker.sh
index e81832c..6765493 100644
--- a/engine/docker.sh
+++ b/engine/docker.sh
@@ -229,7 +229,7 @@ function build_image() {
_container_mount_portage='false'
_status_msg="commit ${run_id} as image ${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}"
- pwrap 'nolog' "${DOCKER}" commit "${DOCKER_COMMIT_OPTS}" "${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \
+ pwrap 'nolog' "${DOCKER}" commit ${DOCKER_COMMIT_OPTS} "${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \
|| die "${_status_msg}"
|
edannenberg
added a commit
that referenced
this pull request
May 14, 2019
Owner
|
My bad, somewhat blindly fixed the shellcheck error for that. Fixed. |
edannenberg
pushed a commit
that referenced
this pull request
Apr 14, 2020
>=libpod-1.8.0 now supports the -f argument for image prune
berney
added a commit
to berney/kubler
that referenced
this pull request
Jul 8, 2021
edannenberg
pushed a commit
that referenced
this pull request
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR related to #159