Open
Conversation
Owner
|
Hi Max, wow, very nice! I'm still on the road to recovery but gonna have a deeper look at this asap. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Erik,
I hope you are fully recovered.
I have finally found some time to get some basic unit / integration tests written for Kubler. As you can see this turned into a bit more of a project than I had intended...
The first five commits below add basic
shellcheckand testing functionality which will be run on every commit. If the tests pass the liveebuildwill be automatically updated in the repo if necessary. When a new release is made the current liveebuildwill be used as a template, best possiblekeywordswill be calculated andrepomanused to check validity - a pull request will then be created against the target repo. The final action (maintain) keeps thekeywordsvariable optimal on a schedule.The actions listed are mostly from my hacking-gentoo repository apart from shellcheck which is from my hacking-actions repository. They have all been fairly thoroughly tested in my other repos. To use these actions you will need to make some minor modifications when importing them, mainly changing the target repository name for commits. You will also need to create a deploy key-pair and API access-token and configure them as secrets - see the instructions in the readme files for the action in question.
The next five commits are some basic tests and some minor
shellcheckfixes - theshellcheckaction found some more shell files!The final commit modifies the dep-graph command to be capable of handling circular dependencies (without crashing) and correctly rendering them (with tests).
I have more in my repository but am having trouble with the final few features (unit testing of built images, test dependencies, etc). Can you try and rebuild the
arg-bashparsing (usingargbash-refresh.sh) as when I have tried the code it generates is very different to the current tree (even usingargbash-2.3.0). I need to add a--pretendoption so I can check that thebuildcommand correctly detects circular parent / test dependencies and that it builds things in the correct order. Thanks!Feel free to cherry-pick things if you only like some of them.