Small performance fixes for usage in high-load situations #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unispezi
commented
Oct 1, 2018
Unispezi
commented
- bigInts now held in fields to reduce number of short-lived objects created by isInRange()
- unused field this.cidr removed
- new isInRange(InetAddress) so you can avoid string parsing if you already have an InetAddress
- early return in isInRange() to reduce number of comparison for out-of-range addresses
- bigInts now held in fields to reduce number of short-lived objects created by isInRange() - unused field this.cidr removed - new isInRange(InetAddress) so you can avoid string parsing if you already have an InetAddress - early return in isInRange() to reduce number of comparison for out-of-range addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.