Fix swapped action order in godot_env.py #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-267
changed the title
Ivan-267
changed the title
edbeeching
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #234
Action order gets sorted alphabetically by
spaces.Dictwhen we give it a dictionary.As a quick fix without changing other code sections, we convert the dictionary to list.
Still not properly tested for any issues that might be introduced, but it seems to preserve action order when using
print(env.action_space). Check the issue for more detail.Edit:
Personally I only checked once with SB3 for now, will check a bit more (at least with SB3) when I can. Tests passed so hopefully other frameworks will work too.
Seems to work OK in Godot after SB3 training too. We had a similar issue before, fixed by using an OrderedDict then, now as the issue has occurred again, using a list fixes it.