onnx inference: support whole observation dictionary as input to the onnx model #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nijco
changed the title
Ivan-267
reviewed
Apr 7, 2025
Ivan-267
reviewed
Apr 7, 2025
Collaborator
|
Thanks for this PR and the other PR on the main repository, just confirming I will check them when possible, but it might take me some days however. |
Co-authored-by: Ivan-267 <[email protected]>
Co-authored-by: Ivan-267 <[email protected]>
Ivan-267
approved these changes
Apr 30, 2025
Collaborator
Ivan-267
left a comment
Ivan-267
left a comment
There was a problem hiding this comment.
Thanks for the PR and the clarifications on the edbeeching/godot_rl_agents#231 PR, I performed a quick test.
Collaborator
|
@edbeeching should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the onnx inference only takes into account the "obs" key from each agent's observation dictionary. The changes in this PR allow each aspect of the observation to be used as input to the onnx model.
For this change, the 'obs' parameter of ONNXInference.RunInference is changed from Godot Array to Godot Dictionary. This actually aligns the implementation with the current documentation in 'docs/ONNXInference.xml/Run' that states: "<param name="obs">Dictionary containing all observations.</param>".
This PR should be non-breaking and is related to this PR (but it is not depending on it to work): [edbeeching/godot_rl_agents/pull/231]
Please let me know if any changes or information are necessary to get this merged.