Skip to content

Convert instruction now supports IsInst #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: metadata-provider
Choose a base branch
from
Open

Convert instruction now supports IsInst #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70d3255
IsInst is not the same as Cast for convert instructions
fcurdi Dec 19, 2019
308a83c
remove part that is going to be on other PR
fcurdi Dec 22, 2019
75f2115
whitespace
fcurdi Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CCIProvider/OperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ public static BasicOperation ToBasicOperation(Cci.OperationCode opcode)
public static ConvertOperation ToConvertOperation(Cci.OperationCode opcode)
{
switch (opcode)
{
case Cci.OperationCode.Castclass:
case Cci.OperationCode.Isinst: return ConvertOperation.Cast;
{
case Cci.OperationCode.Isinst: return ConvertOperation.IsInst;
case Cci.OperationCode.Castclass: return ConvertOperation.Cast;
case Cci.OperationCode.Box: return ConvertOperation.Box;
case Cci.OperationCode.Unbox: return ConvertOperation.UnboxPtr;
case Cci.OperationCode.Unbox_Any: return ConvertOperation.Unbox;
Expand Down
4 changes: 2 additions & 2 deletions MetadataProvider/OperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ public static ConvertOperation ToConvertOperation(SRM.ILOpCode opcode)
{
switch (opcode)
{
case SRM.ILOpCode.Castclass:
case SRM.ILOpCode.Isinst: return ConvertOperation.Cast;
case SRM.ILOpCode.Isinst: return ConvertOperation.IsInst;
case SRM.ILOpCode.Castclass: return ConvertOperation.Cast;
case SRM.ILOpCode.Box: return ConvertOperation.Box;
case SRM.ILOpCode.Unbox: return ConvertOperation.UnboxPtr;
case SRM.ILOpCode.Unbox_any: return ConvertOperation.Unbox;
Expand Down
1 change: 1 addition & 0 deletions Model/Bytecode/Instructions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public enum BranchOperation
public enum ConvertOperation
{
Conv,
IsInst,
Cast,
Box,
Unbox,
Expand Down