feat: add support for gateway to reject sql queries #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
force-pushed
the
joseph/sql-238-create-a-pr-for-the-en-gateway-to-deny-sql-queries
branch
4 times, most recently
from
2176b65 to
60b1af7
Compare
suchapalaver
force-pushed
the
joseph/sql-238-create-a-pr-for-the-en-gateway-to-deny-sql-queries
branch
from
60b1af7 to
fbf4364
Compare
gusinacio
reviewed
May 2, 2024
fix: add selection set to query validation Fixes STU-218 Signed-off-by: Gustavo Inacio <[email protected]> feat: share functionality across sql- and non-sql gateways test: ensure nested sql fields are not rejected
suchapalaver
force-pushed
the
joseph/sql-238-create-a-pr-for-the-en-gateway-to-deny-sql-queries
branch
from
fbf4364 to
6dcae77
Compare
Merged
Theodus
added a commit
that referenced
this pull request
May 17, 2024
suchapalaver
deleted the
joseph/sql-238-create-a-pr-for-the-en-gateway-to-deny-sql-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As work takes place to add support for SQL queries the Gateway should invalidate such queries in the meantime.
Solution
The Gateway should reject queries containing SQL fields.
We want to reuse this code in the
sql-gateway. Therefore we use theSqlFieldBehaviorenum to inject the desired behavior.Signed-off-by: Joseph Livesey [email protected]