feat(fileTransfer): add streaming to fifo

[joshuachp]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 84.33735% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (66f0bf9) to head (107cdce).

Files with missing lines	Patch %	Lines
src/file_transfer/file_system/stream/mod.rs	38.0%	13 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #681   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        116     118    +2     
  Lines      16827   16908   +81     
=====================================
+ Hits       13711   13779   +68     
- Misses      3116    3129   +13     

Files with missing lines	Coverage Δ
src/file_transfer/file_system/store.rs	94.5% <100.0%> (ø)
src/file_transfer/file_system/stream/unix.rs	100.0% <100.0%> (ø)
src/file_transfer/interface.rs	57.6% <ø> (-1.6%)	⬇️
src/file_transfer/mod.rs	66.6% <100.0%> (+12.8%)	⬆️
src/file_transfer/request.rs	97.7% <100.0%> (+<0.1%)	⬆️
src/file_transfer/file_system/stream/mod.rs	38.0% <38.0%> (ø)

Components	Coverage Δ
runtime	79.5% <84.3%> (+<0.1%)	⬆️
containers	87.4% <ø> (ø)
forwarder	93.3% <ø> (ø)

[harlem88]

I think cfg_if! is redundant here, since you already define SysPipe as a type alias for the OS-specific struct, you don't need to re-evaluate the OS.

Suggested change

	cfg_if::cfg_if! {
	if #[cfg(unix)] {
	pub(crate) type SysPipe = self::unix::MakeFifo;
	} else if #[cfg(windows)] {
	pub(crate) type SysPipe = self::windows::MakeNamedPipe;
	}
	}
	#[cfg(unix)]
	pub(crate) type SysPipe = self::unix::MakeFifo;
	#[cfg(windows)]
	pub(crate) type SysPipe = self::windows::MakeNamedPipe;

[harlem88]

Since int the change above SysPipe resolves to the correct OS struct at compile time,
you can just call its inherent new() method.

Suggested change

	impl Streaming<SysPipe> {
	pub(crate) fn with_sys() -> Self {
	cfg_if::cfg_if! {
	if #[cfg(unix)] {
	Self {
	sys: self::unix::MakeFifo::new(),
	}
	} else if #[cfg(windows)] {
	Self {
	sys: self::windows::MakeNamedPipe::new(),
	}
	}
	}
	}
	}
	impl Streaming<SysPipe> {
	pub(crate) fn with_sys() -> Self {
	Self {
	sys: SysPipe::new(),
	}
	}
	}

[harlem88]

nit: I don't have a strong opinion on this, but maybe for a zero-argument constructor, in Rust, it is better to use new() method, or can they have a different types of Streaming here, like sys api etc?

Suggested change

	stream: Streaming::with_sys(),
	stream: Streaming::new(),