feat: add tag subscription#1218
Open
osmanhadzic wants to merge 1 commit intoedgehog-device-manager:mainfrom
Open
feat: add tag subscription#1218osmanhadzic wants to merge 1 commit intoedgehog-device-manager:mainfrom
osmanhadzic wants to merge 1 commit intoedgehog-device-manager:mainfrom
Conversation
- add GraphQL subscription for tag creation events - add test coverage for tag subscriptions to ensure functionality works as expected Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
feature/add-tag-sub
branch
from
f8570a8 to
4f686db
Compare
Pull Request Test Coverage Report for Build 4f686dbb053cad2c9c96490be9a1e7beff95ad56-PR-1218Details
💛 - Coveralls |
osmanhadzic
changed the title
Collaborator
|
The code looks good to me. I’m just not entirely convinced we need to enable this subscription at the moment. Since we don’t expose GraphQL mutations for this resource, the only way to trigger the create action is via the Device resource mutations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GraphQL subscription for tag creation events.
Add test coverage to verify that tag subscriptions work as expected.
Enables clients to receive real-time updates when new tags are created.
Improves responsiveness and removes the need for polling.
Ensures correctness and stability of the subscription layer through automated tests.
Testing
Subscriptions for
updateanddestroyevents were not implemented, as there is currently no action in the system capable of triggering those events.Change Title
Checklist
Further Comments (optional)
Screenshots / Demos (optional)