Skip to content

chore: fix and improve CI workflows and docker compose#1277

Merged
lusergit merged 2 commits intoedgehog-device-manager:mainfrom
OmarBrbutovic:fix_ci_workflows
Mar 10, 2026
Merged

chore: fix and improve CI workflows and docker compose#1277
lusergit merged 2 commits intoedgehog-device-manager:mainfrom
OmarBrbutovic:fix_ci_workflows

Conversation

@OmarBrbutovic
Copy link
Collaborator

@OmarBrbutovic OmarBrbutovic commented Mar 10, 2026

Fix and improve CI workflows and docker compose

  • Fix CodeQL code scanning alert: add codeql job to frontend-ci.yaml so GitHub can track the configuration on the main branch
  • Fix broken reusable workflow reference: docs-workflow.yaml → docs-ci.yaml in backend-ci.yaml
  • Fix release-ci.yaml: publish condition was a string comparison outside ${{ }}, not a boolean; fix make-release outputs mapping (missing id and outputs block); add secrets: inherit for DOCS_DEPLOY_KEY
  • Fix doc-publish composite action: composite actions cannot access the secrets context directly; expose deploy key as an explicit input
  • Fix frontend-build.yaml name (was "frontend check types", conflicting with frontend-types.yaml)
  • Pin coverallsapp/github-action from @master to @v2
  • Rename backend-minio.yaml → backend-rustfs.yaml to match its content
  • Remove unused POSTGRES_HOST env var from backend CI workflows; the backend uses DATABASE_HOSTNAME, configured in config/test.exs
  • Align backend workflow names to a consistent lowercase pattern matching frontend conventions (e.g. "backend check format")
  • Update typos to v1.44.0 and replace wget install with crate-ci/typos action in commit-lint.yaml; write commit messages to a temp file so the action can scan them
  • Fix docker-compose.yml: corrupted REGISTRY_AUTH value, add healthcheck to rustfs using curl so dependent services can rely on it being ready before proceeding, set rustfs-init to wait on rustfs, add --ignore-existing to mc mb to make bucket creation idempotent

Checklist

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added or updated documentation (if appropriate)

Further Comments (optional)

Screenshots / Demos (optional)

Updated dependencies that only include minor changes
Command:
`npm update`

Signed-off-by: Jasmina <jasmina.piric@secomind.com>
@OmarBrbutovic OmarBrbutovic force-pushed the fix_ci_workflows branch 2 times, most recently from e9237e6 to 50d4a15 Compare March 10, 2026 15:05
@OmarBrbutovic OmarBrbutovic added the chore Maintenance chore label Mar 10, 2026
- Fix CodeQL code scanning alert: add `codeql` job to frontend-ci.yaml
  so GitHub can track the configuration on the main branch
- Fix broken reusable workflow reference: docs-workflow.yaml →
  docs-ci.yaml in backend-ci.yaml
- Fix release-ci.yaml: publish condition was a string comparison outside
  ${{ }}, not a boolean; fix make-release outputs mapping (missing `id`
  and `outputs` block); add `secrets: inherit` for DOCS_DEPLOY_KEY
- Fix doc-publish composite action: composite actions cannot access the
  secrets context directly; expose deploy key as an explicit input
- Fix frontend-build.yaml name (was "frontend check types", conflicting
  with frontend-types.yaml)
- Pin coverallsapp/github-action from @master to @v2
- Rename backend-minio.yaml → backend-rustfs.yaml to match its content
- Remove unused POSTGRES_HOST env var from backend CI workflows; the
  backend uses DATABASE_HOSTNAME, configured in config/test.exs
- Align backend workflow names to a consistent lowercase pattern
  matching frontend conventions (e.g. "backend check format")
- Update typos to v1.44.0 and replace wget install with
  crate-ci/typos action in commit-lint.yaml; write commit messages to
  a temp file so the action can scan them
- Fix docker-compose.yml: corrupted REGISTRY_AUTH value, add healthcheck
  to rustfs using curl so dependent services can rely on it being
  ready before proceeding, set rustfs-init to wait on rustfs, add
  --ignore-existing to mc mb to make bucket creation idempotent

Signed-off-by: Omar <omar.brbutovic@secomind.com>
@lusergit
Copy link
Collaborator

/fast-forward

@lusergit lusergit merged commit 678266b into edgehog-device-manager:main Mar 10, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants