e2e: use PatchNamespace for regression test cases#2197
Open
e2e: use PatchNamespace for regression test cases#2197
Conversation
burgerdev
force-pushed
the
burgerdev/add-namespace
branch
from
dfb4046 to
8ed029c
Compare
Member
Author
|
Thanks for spotting that. Naturally, it turned out that we were still not covering all pod-generating resources, so I added a few more tests. |
burgerdev
force-pushed
the
burgerdev/add-namespace
branch
from
8ed029c to
5278d30
Compare
sespiros
approved these changes
Feb 20, 2026
Contributor
sespiros
left a comment
sespiros
left a comment
There was a problem hiding this comment.
nice, thanks. Approving with a suggested minor addition.
| "cronjob": {resource: cronjob}, | ||
| "daemonset": {resource: daemonset}, | ||
| "pod": {resource: pod}, | ||
| "replicationController": {resource: replicationController}, |
Contributor
There was a problem hiding this comment.
is it necessary to test here for replicationSet and statefulSet too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why we did not use the function back when we wrote the regression tests, maybe it was not there yet. I needed to fix the switch statement to make it deal with
ReplicationControllerandReplicaSet, but inly introduced a test case for the former because the latter is somewhat deprecated anyway.