Conversation
thomasten
approved these changes
Jan 16, 2026
verify/verify.go
Outdated
| logger.V(2).Info("Getting TCB Info: ", tcbInfoURL) | ||
| header, body, err := trust.GetWith(ctx, getter, tcbInfoURL) | ||
| if err != nil { | ||
| // TODO(burgerdev): 410 means evaluationDataNumber is too old, maybe just query without it? |
Member
There was a problem hiding this comment.
May be obvious, but to summarize:
- Security-wise fine as long as the check below is there
- May improve availability
- May hide errors
Both options are fine with me. I don't have a preference what to do here.
Member
Author
There was a problem hiding this comment.
After revisiting the code, I found that the HTTPSGetter interface does not forward HTTP status codes. Since it's a simple change on the caller side to update the expected number, whereas it's complicated to check here (forwarding the errors, and the error hiding you observed), I'm going to keep it as-is.
burgerdev
force-pushed
the
evalnum
branch
2 times, most recently
from
c06f090 to
612f055
Compare
Signed-off-by: Markus Rudy <mr@edgeless.systems>
Member
Author
|
I simplified the code a bit, but the behaviour remains the same as in the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.