Skip to content

Remove requests from public interfaces #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mr0grog wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Remove requests from public interfaces #157

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bdbdc06
Create new `_http` module, move hacks to it
Mr0grog Dec 26, 2023
18527aa
Move all *requests* stuff (except errors) to new adapter
Mr0grog Dec 26, 2023
01e6d83
Update docs for WaybackSession
Mr0grog Dec 29, 2023
1eb3e17
Add `InternalHttpResponse` to provide a non-requests Response interface
Mr0grog Dec 29, 2023
ccc8f40
Delegate to requests for encoding sniffing
Mr0grog Dec 29, 2023
0f3ef22
Fix locking and caching issues in `close()`
Mr0grog Dec 29, 2023
172e6a6
Split response API from reqeusts-specific implementation
Mr0grog Dec 29, 2023
4843ed4
Add docs and type annotations to adapters
Mr0grog Dec 29, 2023
9d9a16c
Break Session functionality into separate methods
Mr0grog Jan 2, 2024
de28981
Clarify redirect_url docs
Mr0grog Jan 2, 2024
f2eb7e5
Rename allow_redirects -> follow_redirects
Mr0grog Jan 2, 2024
086e034
Limit `noqa` to just the unused import rule
Mr0grog Jan 4, 2024
2f48476
Add user agent test
Mr0grog Jan 4, 2024
f43ba0a
Move all WaybackSession functionality to adapters
Mr0grog Jan 4, 2024
0ec7811
Forgot the dict merge operator is Python 3.9+
Mr0grog Jan 5, 2024
cf6d879
Delegate default header handling to requests
Mr0grog Jan 5, 2024
994c8b7
Oops, stream should be true
Mr0grog Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/source/usage.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,10 @@ Memento API. We implement a Python client that can speak both.
.. automethod:: close
.. automethod:: parse_memento_headers

.. autoclass:: wayback.WaybackSession
.. autoclass:: wayback.WaybackHttpAdapter

.. automethod:: reset
.. automethod:: request
.. automethod:: close

Utilities
---------
Expand Down Expand Up @@ -150,4 +151,4 @@ Exception Classes

.. autoclass:: wayback.exceptions.WaybackRetryError

.. autoclass:: wayback.exceptions.SessionClosedError
.. autoclass:: wayback.exceptions.AlreadyClosedError
11 changes: 6 additions & 5 deletions src/wayback/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
from ._version import __version__, __version_tuple__ # noqa: F401

from ._utils import memento_url_data, RateLimit # noqa
from ._utils import memento_url_data, RateLimit # noqa: F401

from ._models import ( # noqa
from ._models import ( # noqa: F401
CdxRecord,
Memento)

from ._client import ( # noqa
from ._client import ( # noqa: F401
Mode,
WaybackClient,
WaybackSession)
WaybackClient)

from ._http import WaybackHttpAdapter # noqa: F401
Loading