Open
Conversation
…l number representation, for example:
"\\x{1F4E3}" → #\📣
cage2
commented
Oct 31, 2024
| (number (get-number lexer :radix 16 :max-length 2 :no-whitespace-p t))) | ||
| ;; note that it is OK if \x is followed by zero digits | ||
| (make-char-from-code number error-pos))) | ||
| (if (looking-at-p lexer #\{) ; parsing \x{####...} |
Author
There was a problem hiding this comment.
maybe would be a good idea to refactor out this code in a new function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added support for specify a character using unrestricted hexadecimal number representation, for example:
also spaces between braces is supported:
This patch is a just a bit more than a POC, as I never touched
cl-ppcrecode before; but seems to works and I think it is a good start. Of course review or critics, suggestions are welcome!Bye!
C.