Skip to content

Conversation

@eiffel-fl
Copy link

Hi.

First, I do hope you are fine and the same for your relatives.

Originally, I submitted this code to the original cpython repository (python#22477).
@taleinat informed me that there was already a PR (python#20677) to solve this documentation problem.
After discussing with him he suggested to me to add my code to your fork, then you can merge my commit with yours and add the two modifications (both python documentation and C documentation to cpython).

If there is any problem or if I was unclear do not hesitate to say it, so I will improve it.

Best regards.

corona10 and others added 19 commits June 6, 2020 00:01
…ythonGH-20659)

* Refresh importlib.metadata from importlib_metadata 1.6.1.

* 📜🤖 Added by blurb_it.

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
…0666)

* bpo-40880: Fix invalid read in newline_in_string in pegen.c

* Update Parser/pegen/pegen.c

Co-authored-by: Lysandros Nikolaou <[email protected]>

* Add NEWS entry

Co-authored-by: Lysandros Nikolaou <[email protected]>
This is not part of the limited API but makes the buffer slots available for type specs.
The documentation is now clearer than before.

This commit should help pandas-dev/pandas#36745.
@taleinat
Copy link

taleinat commented Oct 5, 2020

@eiffel-fl, I think this PR should be against the "bpo-40643" branch in this repo used for PR python#20677, rather than the "master" branch.

@eiffel-fl eiffel-fl changed the base branch from master to bpo-40643 October 5, 2020 12:21
@eiffel-fl
Copy link
Author

That's a good point! Thank you for the review!
Normally I modified it to be against bpo-40643.

edison12a pushed a commit that referenced this pull request May 19, 2022
…python#91466)

Fix an uninitialized bool in exception print context.
    
`struct exception_print_context.need_close` was uninitialized.
    
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
    
https://oss-fuzz.com/testcase-detail/6217746058182656
    
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
    #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
    #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
    python#2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
    python#3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
    
Pretty obvious what the ommission was upon code inspection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.