Add custom variable 'eca-find-root-for-buffer-function #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdallo
reviewed
Oct 23, 2025
eca-util.el
Outdated
| :group 'eca) | ||
|
|
||
| (defcustom eca-find-root-for-buffer-function 'eca-find-root-for-buffer | ||
| "Function for getting the project root using git falling back to file directory." |
Member
There was a problem hiding this comment.
I think this docstring is specific for eca-find-root-for-buffer right? maybe it should be more generic
ericdallo
reviewed
Oct 23, 2025
eca-util.el
Outdated
| :type 'boolean | ||
| :group 'eca) | ||
|
|
||
| (defcustom eca-find-root-for-buffer-function 'eca-find-root-for-buffer |
Member
There was a problem hiding this comment.
Suggested change
| (defcustom eca-find-root-for-buffer-function 'eca-find-root-for-buffer | |
| (defcustom eca-find-root-for-buffer-function #'eca-find-root-for-buffer |
There are cases in which the current project root is not the actual working root, for instance, a monorepo. This change make allow customizing the `eca-find-root-for-buffer-function`.
bobrowadam
force-pushed
the
eca-find-root-for-buffer-function
branch
from
dcdba07 to
65fb089
Compare
ericdallo
approved these changes
Oct 23, 2025
Member
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases in which the current project root is not the actual working root, for instance, a monorepo.
This change allows customizing the
eca-find-root-for-buffer-functionwith eca-find-root-for-buffer` as the default.