Skip to content

Fix flymake and lsp-mode diagnostics tools #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericdallo merged 1 commit into from
Oct 29, 2025
Merged

Fix flymake and lsp-mode diagnostics tools #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions eca-editor.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,18 @@ If URI is nil find all diagnostics otherwise filter to that uri."
(end-r (lsp-get range :end)))
(push (list :uri uri
:severity (eca-editor--lsp-to-eca-severity (lsp-get it :severity))
:code (lsp-get it :code)
:code (when-let ((code (lsp-get it :code)))
(if (symbolp code)
(symbol-name code)
(format "%s" code)))
:range (list :start (list :line (lsp-get start-r :line)
:character (lsp-get start-r :character))
:end (list :line (lsp-get end-r :line)
:character (lsp-get end-r :character)))
:source (lsp-get it :source)
:source (when-let ((source (lsp-get it :source)))
(if (symbolp source)
(symbol-name source)
(format "%s" source)))
:message (lsp-get it :message))
eca-diagnostics))
lsp-diagnostics)))
Expand All @@ -91,12 +97,18 @@ If URI is nil find all diagnostics otherwise filter to that uri."
(end-col (current-column)))
(list :uri (eca--path-to-uri (buffer-file-name (flymake-diagnostic-buffer it)))
:severity (eca-editor--flymake-to-eca-severity (flymake-diagnostic-type it))
:code (flymake-diagnostic-code it)
:code (when-let ((code (flymake-diagnostic-code it)))
(if (symbolp code)
(symbol-name code)
(format "%s" code)))
:range (list :start (list :line beg-line
:character beg-col)
:end (list :line end-line
:character end-col))
:source (flymake-diagnostic-backend it)
:source (when-let ((backend (flymake-diagnostic-backend it)))
(if (symbolp backend)
(symbol-name backend)
(format "%s" backend)))
:message (flymake-diagnostic-text it)))))
(flymake--project-diagnostics))))

Expand Down