Support MS-windows line edings in view_ediff #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdallo
reviewed
Nov 3, 2025
ericdallo
merged commit fffa7ed
into
editor-code-assistant:master
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you please consider patch to fix the issue with empty buffers in
view_ediffon Windows? It addresses #86.The problem arises because both
eca-diffand bufferinsertexpect line endings to be\n, but diffs on Windows come back from the server with\r\nendings.I’ve taken the liberty of adding a test for the fix using
Buttercupand created the first CHANGELOG entry, but I can remove them if there are other plans or preferences.Thanks