Improved flaky test #150
Merged
Improved flaky test #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool-calls-with-prompt-stop-test was falky in CI/CD. Likely because it relied on sleep times. Added promises to the test to coordinate between the concurrent tool calls and the prompt stop. Hopefully, this works better. Changed tool-calls-with-prompt-stop to tool-calls-with-prompt-stop-test for consistency. Fixed a reflection warning in deep-sleep by casting the sleep arg to long.
1 task
Contributor
Author
|
The failing tests seems unrelated to this PR. |
ericdallo
approved these changes
Oct 9, 2025
Member
ericdallo
left a comment
ericdallo
left a comment
There was a problem hiding this comment.
Looks good, I will fix windows ones soon
Member
|
@bombaywalla am I wrong or the macos one froze on your test? |
Contributor
Author
|
Looks that way. |
In order to make the tests more resilient, added timeouts to derefs so that the tests would not hang. Adjusted the sleeps so that there was a better chance that the tests would not be flaky.
Contributor
Author
|
I did some defensive programming and added timeouts to the derefs so that the tests should not hang. The failing tests in the PR seem to be unrelated to my changes. Hope this works better. |
ericdallo
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.