Skip to content

Conversation

@zikajk
Copy link
Member

@zikajk zikajk commented Nov 24, 2025

  • I added a entry in changelog under unreleased section.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for new AI models to the github-copilot provider configuration, expanding the available model options for users with GitHub Copilot access. The changes include adding GPT-5.1 variants, GPT-5-codex, and Gemini-3-pro to both the configuration and integration tests.

  • Added 5 new models to the github-copilot provider: gpt-5.1, gpt-5.1-codex, gpt-5.1-codex-mini, gpt-5-codex, and gemini-3-pro
  • Updated integration tests to verify the new models are properly initialized
  • Added a changelog entry documenting the new model support

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/eca/config.clj Added 5 new model entries to the github-copilot provider configuration
integration-test/integration/initialize_test.clj Updated both test cases to include the new models in expected model lists
CHANGELOG.md Added changelog entry for the new models (contains a spelling error)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CHANGELOG.md Outdated
# Changelog

## Unreleased
- Add new OpenAI and Gemini models to Github config.
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Github" should be spelled "GitHub" (with a capital H).

Suggested change
- Add new OpenAI and Gemini models to Github config.
- Add new OpenAI and Gemini models to GitHub config.

Copilot uses AI. Check for mistakes.
@zikajk zikajk force-pushed the update-copilot-models branch 2 times, most recently from 4e95eb7 to 3fdbc1f Compare November 24, 2025 16:51
@zikajk
Copy link
Member Author

zikajk commented Nov 24, 2025

@ericdallo There is a problem with Gemini responses that should be fixed first:

'https://api.githubcopilot.com/chat/completions'
[OPENAI-CHAT] 4813 Unexpected response status: %s body: %s 400 {"error":{"message":"invalid request body","code":"invalid_request_body"}}

@ericdallo
Copy link
Member

Hum, we need to understand if we need to change the body for that model, maybe do in other PR the gemini?

@zikajk zikajk force-pushed the update-copilot-models branch 2 times, most recently from 8120e04 to 835b654 Compare November 25, 2025 07:41
@zikajk zikajk force-pushed the update-copilot-models branch from 835b654 to 78bc1b6 Compare November 25, 2025 07:43
@zikajk
Copy link
Member Author

zikajk commented Nov 25, 2025

Agree, done :-)

@ericdallo ericdallo merged commit 5b5c6f1 into master Nov 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants