-
Notifications
You must be signed in to change notification settings - Fork 67
fix production build and migrate from webpack to vite #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bettysteger please fill the description of the PR carefully. |
I updated the description, is this enough? |
|
Your current description does not explain the problem, its reason and why your solution is the best choice. The original issue caused by mismatched node.js version. This repo likely uses outdated node 16, but we don't fix the exact version of node and ubuntu in CI: and likely So please:
|
|
@bettysteger hey, would you finish this fix? |
@neSpecc ah sorry i forgot, yes i can take a look today! |
|
@neSpecc i hope that's ok: i migrated from webpack to vite and added the dev example. i got the code mainly from editor-js/image and editor-js/checklist (vite.config.js from checklist because no typescript used) |
neSpecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, should be tested.
Also, please fix the supported Node version:
- in package.json
- in
.nvmrc
package.json
Outdated
| "to-string-loader": "^1.2.0", | ||
| "webpack": "^4.29.6", | ||
| "webpack-cli": "^3.3.0" | ||
| "@codexteam/ajax": "^4.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codexteam/ajax looks like production dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will move, but in https://github.com/editor-js/image/blob/master/package.json it is also under devDependencies
to which version? there is no defined version in https://github.com/editor-js/image/blob/master/package.json and there is no .nvmrc in the ImageTool |
yep and that's the root of the problem you're trying to solve.
Which version did you used while testing your changes? We need to lock the latest one supported by our dependencies |
|
@neSpecc i used v24.6.0 locally to test |
so lock it if it is working ok |
The production build is failing, fixing the error of the github Action: https://github.com/editor-js/attaches/actions/runs/18371256573/job/52334851671#step:5:1