chore(ui,core,sdk,dom-adapters): dom-adapters depends on event bus #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from ef56ec3
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 95.98% | 835/870 |
| 🟢 | Branches | 96% | 216/225 |
| 🟢 | Functions | 87.67% | 199/227 |
| 🟢 | Lines | 95.83% | 805/840 |
Test suite run success
411 tests passing in 25 suites.
Report generated by 🧪jest coverage report action from ef56ec3
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 98.03% | 149/152 |
| 🟢 | Branches | 91.8% | 56/61 |
| 🟢 | Functions | 94.74% | 18/19 |
| 🟢 | Lines | 98% | 147/150 |
Test suite run success
67 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from ef56ec3
gohabereg
approved these changes
Apr 10, 2025
packages/ui/src/Blocks/Blocks.ts
Outdated
|
|
||
| /** | ||
| * Prepares blocks holder element | ||
| * @param editorHolder |
e11sy
approved these changes
Apr 10, 2025
|
⏭️ No files to mutate for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there will be a parent contenteditable, we'll listed
beforeinputon it, then dispatchui:before-inputevent. BlockToolAdapter will handle it.This PR contains preparations for that:
EventBusmoved from Core to SDK