Skip to content

imp(dom-adapters): save formatting on block split #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
e11sy merged 8 commits into from
Apr 10, 2025
Merged

imp(dom-adapters): save formatting on block split #105

e11sy merged 8 commits into from
Apr 10, 2025

Conversation

@e11sy
Copy link
Contributor

@e11sy e11sy commented Apr 10, 2025

Changes

  • Now fragments from extracted part of input would be moved to the new inserted block with adjusted text ranges
  • Now CaretAdapter covers the case, when model selection and dom selection are in different inputs

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

⏭️ No files to mutate for ./packages/model

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Coverage report for ./packages/dom-adapters

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from dd7aecf

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Coverage report for ./packages/model

St.❔
 Category Percentage Covered / Total
🟢 Statements 99.76% 815/817
🟢 Branches 98.65% 220/223
🟢 Functions 98.5% 197/200
🟢 Lines 99.75% 785/787

Test suite run success

418 tests passing in 25 suites.

Report generated by 🧪jest coverage report action from dd7aecf

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Coverage report for ./packages/collaboration-manager

St.❔
 Category Percentage Covered / Total
🟡 Statements 68.35% 162/237
🟢 Branches 81.33% 61/75
🔴 Functions 58.82% 20/34
🟡 Lines 68.38% 160/234

Test suite run success

67 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from dd7aecf

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

⏭️ No files to mutate for ./packages/dom-adapters

gohabereg
gohabereg reviewed Apr 10, 2025
View reviewed changes
neSpecc
neSpecc reviewed Apr 10, 2025
View reviewed changes
packages/dom-adapters/src/BlockToolAdapter/index.ts Outdated
const relatedFragments = this.#model.getFragments(this.#blockIndex, key, end, currentValue.length);

/**
* Adjust fragments ranges respectfully to the removed text
Copy link
Contributor

@neSpecc neSpecc Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand what does it mean "adjust". Could you write more detailed explanation please?

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Coverage report for ./packages/ot-server

St.❔
 Category Percentage Covered / Total
🟡 Statements 68% 17/25
🔴 Branches 20% 1/5
🟢 Functions 83.33% 5/6
🟡 Lines 65.22% 15/23

Test suite run success

3 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from dd7aecf

@e11sy e11sy added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 8dfd733 Apr 10, 2025
18 checks passed
@e11sy e11sy deleted the save-formatting-on-block-split branch April 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gohabereg gohabereg gohabereg approved these changes

@neSpecc neSpecc neSpecc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@e11sy @neSpecc @gohabereg