Ensure operations are processed synchronously on OT server #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 66a76bd
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 99.76% | 815/817 |
| 🟢 | Branches | 98.65% | 220/223 |
| 🟢 | Functions | 98.5% | 197/200 |
| 🟢 | Lines | 99.75% | 785/787 |
Test suite run success
418 tests passing in 25 suites.
Report generated by 🧪jest coverage report action from 66a76bd
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 73.33% (+5.33% 🔼) |
22/30 |
| 🔴 | Branches | 20% | 1/5 |
| 🟢 | Functions | 85.71% (+2.38% 🔼) |
6/7 |
| 🟡 | Lines | 71.43% (+6.21% 🔼) |
20/28 |
Test suite run success
4 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 66a76bd
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 68.35% | 162/237 |
| 🟢 | Branches | 81.33% | 61/75 |
| 🔴 | Functions | 58.82% | 20/34 |
| 🟡 | Lines | 68.38% | 160/234 |
Test suite run success
67 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 66a76bd
neSpecc
approved these changes
Apr 10, 2025
e11sy
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
DocumentManagerandOTServerclasses to improve the handling of asynchronous operations. The main changes involve modifying theprocessmethod to ensure operations are processed sequentially and updating the tests accordingly.Improvements to
DocumentManager:packages/ot-server/src/DocumentManager.ts: Added a new private member#operationInProcessingto track the currently processed operation. Modified theprocessmethod to await the completion of the previous operation before processing the new one. Added a new method#processNextOperationto handle the actual processing of operations. [1] [2] [3]Updates to tests:
packages/ot-server/src/DocumentManager.spec.ts: Updated multiple test cases to useasyncandawaitfor theprocessmethod to ensure operations are processed sequentially. Added a new test case to verify the correct processing of asynchronous operations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Updates to
OTServer:packages/ot-server/src/OTServer.ts: Modified the#onOperationmethod to be asynchronous and to await the processing of operations by theDocumentManager. Updated the handling of operation messages to useawaitfor theprocessmethod. [1] [2] [3]