Skip to content

Fix issue with multiple inputs editing #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gohabereg merged 1 commit into from
Apr 10, 2025
Merged

Fix issue with multiple inputs editing #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions packages/dom-adapters/src/BlockToolAdapter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,31 @@
import { isNativeInput } from '@editorjs/dom';
import {
type EditorJSModel,
type DataKey,
BlockAddedEvent,
BlockRemovedEvent,
createDataKey,
type DataKey,
type EditorJSModel,
EventAction,
EventType,
IndexBuilder,
type ModelEvents,
TextAddedEvent,
TextRemovedEvent
} from '@editorjs/model';
import type { EventBus } from '@editorjs/sdk';
import { type BlockToolAdapter as BlockToolAdapterInterface, type CoreConfig } from '@editorjs/sdk';
import type { CaretAdapter } from '../CaretAdapter/index.js';
import type { FormattingAdapter } from '../FormattingAdapter/index.js';
import {
findNextHardLineBoundary,
findNextWordBoundary, findPreviousHardLineBoundary,
findNextWordBoundary,
findPreviousHardLineBoundary,
findPreviousWordBoundary,
getAbsoluteRangeOffset,
getBoundaryPointByAbsoluteOffset,
isNonTextInput
} from '../utils/index.js';
import { InputType } from './types/InputType.js';
import { type BlockToolAdapter as BlockToolAdapterInterface, type CoreConfig } from '@editorjs/sdk';
import type { FormattingAdapter } from '../FormattingAdapter/index.js';
import type { EventBus } from '@editorjs/sdk';

/**
* BlockToolAdapter is using inside Block tools to connect browser DOM elements to the model
Expand Down Expand Up @@ -547,6 +550,12 @@ export class BlockToolAdapter implements BlockToolAdapterInterface {
* @param key - data key input is attached to
*/
#handleModelUpdate(event: ModelEvents, input: HTMLElement, key: DataKey): void {
if (event instanceof BlockAddedEvent || event instanceof BlockRemovedEvent) {
if (event.detail.index.blockIndex! <= this.#blockIndex) {
this.#blockIndex += event.detail.action === EventAction.Added ? 1 : -1;
}
}

const isInputNative = isNativeInput(input);

if (isInputNative === true) {
Expand Down