Skip to content

Conversation

@hildjj
Copy link
Collaborator

@hildjj hildjj commented Jun 9, 2025

No description provided.

@hildjj
Copy link
Collaborator Author

hildjj commented Jun 9, 2025

As mentioned in #134.

I'm not convinced about this. Let's discuss.

  1. I'm not sure if the types have much value after this change. It's not going to help interoperability for someone using this in TS to be able to pass the wrong things in, even though the spec allows it.
  2. Is any correct here? Object wasn't right.

@coveralls
Copy link

coveralls commented Jun 9, 2025

Pull Request Test Coverage Report for Build 15567148207

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.883%

Totals Coverage Status
Change from base Build 15544626408: 0.001%
Covered Lines: 714
Relevant Lines: 714

💛 - Coveralls

@SunsetTechuila
Copy link
Member

It's not going to help interoperability for someone using this in TS to be able to pass the wrong things in, even though the spec allows it.

But aren't cores used for getting editorconfig options, rather than setting them? The change I suggested encourages developers to check the values instead of making assumptions

@hildjj hildjj merged commit 294c7c9 into editorconfig:main Jun 10, 2025
10 checks passed
@hildjj hildjj deleted the AddAnyToValues branch June 10, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants