fix: fix floating-promises errors

akx · akx · commit 923ff21658de · 2025-03-23T18:02:59.000+02:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -78,7 +78,7 @@ module.exports = {
         "@typescript-eslint/no-base-to-string": 0,
         "@typescript-eslint/no-misused-promises": 0,
         "@typescript-eslint/require-await": 0,
-        "@typescript-eslint/no-floating-promises": 0,
+        "@typescript-eslint/no-floating-promises": "error",
         "@typescript-eslint/unbound-method": 0,
 
         "@typescript-eslint/no-unsafe-enum-comparison": 0,
diff --git a/src/main.ts b/src/main.ts
@@ -76,7 +76,7 @@ setLcpNativePluginPath(lcpNativePluginPath);
 initSessionsNoHTTP();
 
 if (_VSCODE_LAUNCH === "true") {
-    createStoreFromDi().then((store) => store.dispatch(appActions.initRequest.build()));
+    void createStoreFromDi().then((store) => store.dispatch(appActions.initRequest.build()));
 } else {
     commandLineMainEntry(); // call main fct
 }
diff --git a/src/main/cli/index.ts b/src/main/cli/index.ts
@@ -218,7 +218,7 @@ const yargsInit = () =>
                 if (openPublicationRequestedBool) {
 
                     // flush session because user ask to read a publication
-                    flushSession();
+                    await flushSession();
 
                     // pathArgv can be an url with deepLinkInvocation in windows
                     // https://github.com/oikonomopo/electron-deep-linking-mac-win
@@ -305,7 +305,7 @@ export function commandLineMainEntry(
     debug("processArgv", processArgv, "arg", argFormated);
 
     try {
-        y.parse(argFormated);
+        void y.parse(argFormated);
     } catch (e) {
         debug("YARGS ERROR !!!!!", e);
     }
diff --git a/src/main/redux/sagas/auth.ts b/src/main/redux/sagas/auth.ts
@@ -225,7 +225,7 @@ function* opdsRequestMediaFlow({request, callback}: TregisterHttpProtocolHandler
             return ;
         }
 
-        httpGet(url, {
+        void httpGet(url, {
             ...request,
         }, (response) => {
 
@@ -733,7 +733,7 @@ function createOpdsAuthenticationModalWin(url: string): BrowserWindow | undefine
         win.show();
     });
 
-    win.loadURL(url);
+    void win.loadURL(url);
 
     return win;
 }
diff --git a/src/main/services/device.ts b/src/main/services/device.ts
@@ -65,7 +65,7 @@ export class DeviceIdManager implements IDeviceIDManager {
             const deviceConfig: DeviceConfig = {
                 device_id: deviceId,
             };
-            this.saveDeviceConfigJson(deviceConfig);
+            await this.saveDeviceConfigJson(deviceConfig);
             debug(deviceConfig);
         }
 
@@ -86,7 +86,7 @@ export class DeviceIdManager implements IDeviceIDManager {
             deviceConfig,
         );
         newDeviceConfig[deviceIdKey] = "_"; // deviceId
-        this.saveDeviceConfigJson(newDeviceConfig);
+        await this.saveDeviceConfigJson(newDeviceConfig);
 
         debug("DeviceIdManager recordDeviceID:");
         debug(key);
@@ -104,7 +104,7 @@ export class DeviceIdManager implements IDeviceIDManager {
 
         _cache = conf;
         const str = JSON.stringify(conf);
-        fs.promises.writeFile(lcpLsdDevicesFilePath, str, { encoding: "utf-8" });
+        return fs.promises.writeFile(lcpLsdDevicesFilePath, str, { encoding: "utf-8" });
     }
     private async getDeviceConfigJson(): Promise<DeviceConfig> {
 
diff --git a/src/main/services/lcp.ts b/src/main/services/lcp.ts
@@ -161,7 +161,7 @@ export class LcpManager {
 
         const str = JSON.stringify(allSecrets);
         const encrypted = encryptPersist(str, CONFIGREPOSITORY_LCP_SECRETS, lcpHashesFilePath);
-        fs.promises.writeFile(lcpHashesFilePath, encrypted);
+        return fs.promises.writeFile(lcpHashesFilePath, encrypted);
     }
 
     private async injectLcplIntoZip_(epubPath: string, lcpStr: string) {
diff --git a/src/main/streamer/streamerNoHttp.ts b/src/main/streamer/streamerNoHttp.ts
@@ -178,7 +178,7 @@ const streamProtocolHandlerTunnel = async (
 
     debug("............... streamProtocolHandlerTunnel req.url", req.url);
     req.url = convertCustomSchemeToHttpUrl(req.url);
-    streamProtocolHandler(req, callback);
+    return streamProtocolHandler(req, callback);
 };
 
 // super hacky!! :(
diff --git a/src/main/w3c/audiobooks/toc.ts b/src/main/w3c/audiobooks/toc.ts
@@ -520,7 +520,7 @@ if (require.main === module) {
     `;
 
     const manifestParsed = JSON.parse(w3cManifest);
-    w3cPublicationManifestToReadiumPublicationManifest(manifestParsed, (uniqueResources) => {
+    void w3cPublicationManifestToReadiumPublicationManifest(manifestParsed, (uniqueResources) => {
         const toc = extract_TOC(el, uniqueResources);
 
         console.log("TOC");
@@ -533,5 +533,4 @@ if (require.main === module) {
         return undefined;
 
     });
-
 }
diff --git a/src/renderer/common/apiSubscribe.ts b/src/renderer/common/apiSubscribe.ts
@@ -22,7 +22,7 @@ export function apiSubscribeFactory(storeCb: () => Store<any>) {
         const lastApiSuccess = store.getState().api[LAST_API_SUCCESS_ID];
         let lastSuccessTime = lastApiSuccess?.lastTime || 0;
 
-        cb();
+        void cb();
 
         return store.subscribe(() => {
             const state = store.getState();
@@ -34,7 +34,7 @@ export function apiSubscribeFactory(storeCb: () => Store<any>) {
                 if (!data.error) {
                     const path = `${data.moduleId}/${data.methodId}` as TApiMethodName;
                     if (pathArrayToRefresh.includes(path)) {
-                        cb();
+                        void cb();
                     }
                 }
             }
diff --git a/src/renderer/library/components/dialog/publicationInfos/opdsControls/OpdsControls.tsx b/src/renderer/library/components/dialog/publicationInfos/opdsControls/OpdsControls.tsx
@@ -97,7 +97,7 @@ export class OpdsControls extends React.Component<IProps, undefined> {
                                 onClick={() => {
 
                                     if (ln.type === ContentType.Html || ln.type === ContentType.Xhtml) {
-                                        this.props.link(
+                                        void this.props.link(
                                             ln,
                                             this.props.location,
                                         );
@@ -131,7 +131,7 @@ export class OpdsControls extends React.Component<IProps, undefined> {
                                 onClick={() => {
 
                                     if (ln.type === ContentType.Html || ln.type === ContentType.Xhtml) {
-                                        this.props.link(
+                                        void this.props.link(
                                             ln,
                                             this.props.location,
                                         );
diff --git a/src/renderer/library/index_library.ts b/src/renderer/library/index_library.ts
@@ -66,7 +66,7 @@ initGlobalConverters_GENERIC();
 //     }, 5000);
 // }
 
-ipcRenderer.on(winIpc.CHANNEL, (_0: any, data: winIpc.EventPayload) => {
+ipcRenderer.on(winIpc.CHANNEL, async (_0: any, data: winIpc.EventPayload) => {
     switch (data.type) {
         case winIpc.EventType.IdResponse:
             // Initialize window
@@ -84,7 +84,7 @@ ipcRenderer.on(winIpc.CHANNEL, (_0: any, data: winIpc.EventPayload) => {
             };
             const [store, _reduxHistory] = createStoreFromDi(preloadedState);
             const locale = store.getState().i18n.locale;
-            getTranslator().setLocale(locale);
+            await getTranslator().setLocale(locale);
 
             store.dispatch(winActions.initRequest.build(data.payload.win.identifier));
 
diff --git a/src/renderer/reader/components/ReaderHeader.tsx b/src/renderer/reader/components/ReaderHeader.tsx
@@ -250,7 +250,7 @@ export class ReaderHeader extends React.Component<IProps, IState> {
         }
 
         if (!this.props.isDivina && !this.props.isPdf) {
-            getVoices(/*TODO Param? */).then((voices) => {
+            void getVoices(/*TODO Param? */).then((voices) => {
                 this.setVoices(voices);
             });
         }
diff --git a/src/renderer/reader/index_reader.ts b/src/renderer/reader/index_reader.ts
@@ -46,7 +46,7 @@ initGlobalConverters_GENERIC();
 // }
 
 ipcRenderer.on(readerIpc.CHANNEL,
-    (_0: any, data: readerIpc.EventPayload) => {
+    async (_0: any, data: readerIpc.EventPayload) => {
         switch (data.type) {
             case readerIpc.EventType.request:
                 // Initialize window
@@ -112,7 +112,7 @@ ipcRenderer.on(readerIpc.CHANNEL,
 
                 const store = createStoreFromDi(data.payload);
                 const locale = store.getState().i18n.locale;
-                getTranslator().setLocale(locale);
+                await getTranslator().setLocale(locale);
 
                 store.dispatch(winActions.initRequest.build(data.payload.win.identifier));
 

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ setLcpNativePluginPath(lcpNativePluginPath);`
`76`	`76`	`initSessionsNoHTTP();`
`77`	`77`
`78`	`78`	`if (_VSCODE_LAUNCH === "true") {`
`79`		`- createStoreFromDi().then((store) => store.dispatch(appActions.initRequest.build()));`
	`79`	`+ void createStoreFromDi().then((store) => store.dispatch(appActions.initRequest.build()));`
`80`	`80`	`} else {`
`81`	`81`	`commandLineMainEntry(); // call main fct`
`82`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ function* opdsRequestMediaFlow({request, callback}: TregisterHttpProtocolHandler`
`225`	`225`	`return ;`
`226`	`226`	`}`
`227`	`227`
`228`		`- httpGet(url, {`
	`228`	`+ void httpGet(url, {`
`229`	`229`	`...request,`
`230`	`230`	`}, (response) => {`
`231`	`231`
`@@ -733,7 +733,7 @@ function createOpdsAuthenticationModalWin(url: string): BrowserWindow \| undefine`
`733`	`733`	`win.show();`
`734`	`734`	`});`
`735`	`735`
`736`		`- win.loadURL(url);`
	`736`	`+ void win.loadURL(url);`
`737`	`737`
`738`	`738`	`return win;`
`739`	`739`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ export class LcpManager {`
`161`	`161`
`162`	`162`	`const str = JSON.stringify(allSecrets);`
`163`	`163`	`const encrypted = encryptPersist(str, CONFIGREPOSITORY_LCP_SECRETS, lcpHashesFilePath);`
`164`		`- fs.promises.writeFile(lcpHashesFilePath, encrypted);`
	`164`	`+ return fs.promises.writeFile(lcpHashesFilePath, encrypted);`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`private async injectLcplIntoZip_(epubPath: string, lcpStr: string) {`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export function apiSubscribeFactory(storeCb: () => Store<any>) {`
`22`	`22`	`const lastApiSuccess = store.getState().api[LAST_API_SUCCESS_ID];`
`23`	`23`	`let lastSuccessTime = lastApiSuccess?.lastTime \|\| 0;`
`24`	`24`
`25`		`- cb();`
	`25`	`+ void cb();`
`26`	`26`
`27`	`27`	`return store.subscribe(() => {`
`28`	`28`	`const state = store.getState();`
`@@ -34,7 +34,7 @@ export function apiSubscribeFactory(storeCb: () => Store<any>) {`
`34`	`34`	`if (!data.error) {`
`35`	`35`	const path = `${data.moduleId}/${data.methodId}` as TApiMethodName;
`36`	`36`	`if (pathArrayToRefresh.includes(path)) {`
`37`		`- cb();`
	`37`	`+ void cb();`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`