i have added support for Hindi and Sanskrit for consideration#3176
i have added support for Hindi and Sanskrit for consideration#3176arunshankarv wants to merge 3 commits intoedrlab:developfrom
Conversation
.gitignore
Outdated
| .flox/NPM_PREFIX | ||
| .flox/NPM_CACHE | ||
| .env | ||
| package-lock.json |
There was a problem hiding this comment.
i understand now why this is not recommended; I will remove it as part of my next PR
There was a problem hiding this comment.
fixed in latest commit (not PR as mistakenly stated above)
|
Thanks you very much for your first PR ! We will check the translation |
danielweck
left a comment
danielweck
left a comment
There was a problem hiding this comment.
.gitignore should not be modified, especially package-lock.json which pins the project dependencies.
src/common/services/translator.ts
Outdated
| "ta": "தமிழ் (Tamil)", | ||
| "tr": "Türkçe (Turkish)", | ||
| "hi": "Hindi", | ||
| "sk": "Sanskrit", |
There was a problem hiding this comment.
is there a native script for the English word "Sanskrit"? (same question for "Hindi")
just like the other languages, we can put the English between parentheses, following the native script.
There was a problem hiding this comment.
Hindi : "hi" code with endonym हिन्दी (Hindī)
Sanskrit : "sa" code with endonym संस्कृतम् (Saṃskṛtam)
https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes
There was a problem hiding this comment.
"sk" seems to be for the slovak language
There was a problem hiding this comment.
thanks for flagging this; will be part of my updated PR
There was a problem hiding this comment.
fixed the endonym, renamed sk to sa and the file from sk.json to sa.json for Sanskrit support, and fixed errors in sa.json. These are part of my updated commit (not PR as stated above). Thanks for the help and hope I have it right this time around :-)
…it support, update sa.json to fix missing translations, update endonym for hindi, sanskrit; built and tested against Win11
|
i was having issues building under WSL-2 and had to switch to Windows proper to do the build and test. When i ran the npm install in my Windows 11 env, this time the package.json also saw updates...hope this is ok. |
| "@redux-devtools/extension": "^3.3.0", | ||
| "@rollup/plugin-terser": "^0.4.4", | ||
| "@statoscope/webpack-plugin": "^5.29.0", | ||
| "@types/debug": "^4.1.12", |
There was a problem hiding this comment.
why introduce this new package?
| .flox/NPM_PREFIX | ||
| .flox/NPM_CACHE | ||
| .env | ||
|
|
There was a problem hiding this comment.
IMO this file should not be modified at all by this PR.
4 participants
Using AI agents, i generated hi.json (for Hindi support) and sk.json (for Sanskrit support). I tested it on Windows 11 interactively and confirmed it works. This is my first attempt to collaborate on open source development and so this pull request will be part of my initiation as well :-)