Skip to content

fix unmount cycle of toast component#3450

Open
arthur-lemeur wants to merge 3 commits intodevelopfrom
fix/toast-render-lifecycle
Open

fix unmount cycle of toast component#3450
arthur-lemeur wants to merge 3 commits intodevelopfrom
fix/toast-render-lifecycle

Conversation

@arthur-lemeur
Copy link
Copy Markdown
Collaborator

@arthur-lemeur arthur-lemeur commented Mar 18, 2026

Fixes #3448

@arthur-lemeur arthur-lemeur requested a review from panaC March 18, 2026 09:26
Copy link
Copy Markdown
Member

@panaC panaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but doesn't fix the issue

@danielweck
Copy link
Copy Markdown
Member

Good, but doesn't fix the issue

@panaC , @arthur-lemeur pushed another commit, does it work now?

@arthur-lemeur arthur-lemeur requested a review from panaC March 20, 2026 09:11
@danielweck
Copy link
Copy Markdown
Member

@panaC will you have time early this week to confirm that this PR works? It would be great to fix the bug in 3.4.0

@panaC
Copy link
Copy Markdown
Member

panaC commented Mar 23, 2026

@danielweck There is still an issue with the transitionend event may not fire in some cases.
It would be more robust to handle all related transition events, including transitionrun, transitionstart, and transitioncancel.
Currently, the toast removal logic relies solely on the transitionend event. If this event is not triggered, a div overlay can block interaction with the settings button (except near its border).
To make this more reliable, I think it would be safer to include a fallback mechanism like a timeout, to ensure the toast state stays in sync with the UI.

Copy link
Copy Markdown
Member

@panaC panaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last message.

@arthur-lemeur arthur-lemeur requested a review from panaC March 24, 2026 15:01
@danielweck danielweck requested review from danielweck and removed request for panaC March 27, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ui] Toast notification wrapper remains non-empty after the toast is removed and blocks clicks on Settings

4 participants