Skip to content

review the reader browser window lifecycle in main process#3464

Merged
panaC merged 10 commits intodevelopfrom
review-redux-saga-main
Mar 24, 2026
Merged

review the reader browser window lifecycle in main process#3464
panaC merged 10 commits intodevelopfrom
review-redux-saga-main

Conversation

@panaC
Copy link
Copy Markdown
Member

@panaC panaC commented Mar 23, 2026

Features list:

  • Renamed pubId and winId for clarity and consistency
  • Removed/Comment win.registry redux state/reducer/actions, no longer needed.
  • Added reader_pub from synced actions (sender key)
  • Refactored reader open/close logic to use saga generator actions instead of Redux actions
  • Fixed and improved winBound behavior (new reader windows are offset and no longer overlap the library window)
  • Added readingFinished handling
  • Reviewed browser window startup lifecycle (reader initialization and closing flow)
  • Replaced global reader Redux state persistence with atomic persistence via synced actions (config / locator)
  • Removed the reader session feature (no longer saves and restores multiple reader states across restarts)

@panaC panaC self-assigned this Mar 23, 2026
@panaC
Copy link
Copy Markdown
Member Author

panaC commented Mar 23, 2026

supersede and close #3455

@panaC panaC marked this pull request as ready for review March 23, 2026 21:15
@panaC
Copy link
Copy Markdown
Member Author

panaC commented Mar 23, 2026

Fixes #3439

@panaC panaC merged commit 65abfbc into develop Mar 24, 2026
8 checks passed
@panaC panaC deleted the review-redux-saga-main branch March 24, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant