Homework 2 #3
Open
Homework 2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorodilov
suggested changes
Dec 4, 2022
01/task_01.py
Outdated
| return self.name | ||
|
|
||
| def __eq__(self, other): | ||
| return self.name == other.name and self.price == other.price |
Contributor
There was a problem hiding this comment.
Додай перевірку типів. Бо це спрацює лише для порівняння з об'єктом Product.
01/task_01.py
Outdated
| other.products_list.index(product) | ||
| ] | ||
| self.add_product(product, count) | ||
| return self |
Contributor
There was a problem hiding this comment.
Тут ліпше створити новий об'єкт кошика і повертати його.
01/task_01.py
Outdated
| """Adding products to the cart""" | ||
|
|
||
| if product in self.products_list: | ||
| self.products_count[ |
Contributor
There was a problem hiding this comment.
Ліпше розбивай таке на декілька рядків, або слідуй PEP-8.
Тут все вірно, але у мене очі слізяться коли таке бачу.
01/task_01.py
Outdated
| if isinstance(other, Product): | ||
| self.add_product(other, 1) | ||
| elif isinstance(other, ShoppingCart): | ||
| for product in other.products_list: |
Contributor
There was a problem hiding this comment.
Он же ж тип нормально використовуєш zip ніжче...
Owner
Author
|
Додав перевірку типів в eq. Створив новий об'єкт кошику. Додав окремо рядок для індексу. Змінив на zip в add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding magic methods concerning hometask