Enable easy control of SVG QR code colors and styles#3
Open
jerome-toole wants to merge 1 commit intoeducastellano:masterfrom
Open
Enable easy control of SVG QR code colors and styles#3jerome-toole wants to merge 1 commit intoeducastellano:masterfrom
jerome-toole wants to merge 1 commit intoeducastellano:masterfrom
Conversation
Add part attributes to foreground and background rect element in generateSVG. Add `--qr--fg` and `--qr--bg` CSS variables for easier control of the QR code colors as CSS variables are inherited into the shadow DOM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when this library is used via
qr-code, there's no way to override the colours or styles when in SVG mode.partattributes were previously added to the HTML table QR version, but not the SVG version which prevented any control over those elements when they were in the shadow DOM.If the user only needs to control colours, it's simpler just to give them a CSS custom property to edit as CSS variables are inherited into the shadow DOM. I've added
--qr--fgand--qr--bg.partattributes to generated foreground and background SVG elements.--qr--fgand--qr--bgCSS variables with fallbacks to inline SVG styles for easier control of the QR code colorsThis issue mentioned a similar issue: educastellano/qr-code#20
Thanks for the qr-code library! 👌