fix: fixup theming setup during devstack provisioning #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes: 1. By default, we clone repos with SSH now. Update the REPO_URL accordingly. 2. Updates the relevant lines to setup to setup comprehensive theming correctly.
justinhynes
commented
Mar 13, 2025
| # This script sets up the edX theme in LMS and CMS. | ||
|
|
||
| REPO_URL="https://github.com/edx/edx-themes" | ||
| REPO_URL="git@github.com:edx/edx-themes.git" |
Contributor
Author
There was a problem hiding this comment.
By default make dev.clone moved to cloning via SSH. This updates the theming provisioning script to do the same.
huniafatima-99
approved these changes
Mar 17, 2025
Contributor
|
LGTM, just need to make sure that CI is green. |
Contributor
Author
|
@huniafatima-99 Thanks! I took a look at the error and it seems like a possibly flakey test and/or unrelated to my changes. I'm rerunning the failed test now. Hopefully it passes this time aroun :D. Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
I've completed each of the following or determined they are not applicable: